Skip to content

Remove Welsh feature flag#2015

Merged
thomasiles merged 1 commit into
mainfrom
remove-welsh-feature-flag
Mar 17, 2026
Merged

Remove Welsh feature flag#2015
thomasiles merged 1 commit into
mainfrom
remove-welsh-feature-flag

Conversation

@thomasiles
Copy link
Copy Markdown
Contributor

@thomasiles thomasiles commented Mar 13, 2026

The Welsh feature flag is no longer required now the feature has been released.

This commit removes the terraform variable welsh_enabled and environment variable which controlled the settings in the rails app.

See the PR to remove the flag in the Admin.

What problem does this pull request solve?

Trello card: https://trello.com/c/gI4COCYo/2863-remove-welsh-feature-flag

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

@thomasiles thomasiles marked this pull request as ready for review March 13, 2026 15:56
DavidBiddle
DavidBiddle previously approved these changes Mar 17, 2026
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What you've done here looks good but you've got some merge conflicts - shout if you need a re-review once those are resolved

The Welsh feature flag is no longer required now the feature has been
released.

This commit removes the terraform variable welsh_enabled and environment
variable which controlled the settings in the rails app.
@thomasiles thomasiles added this pull request to the merge queue Mar 17, 2026
Merged via the queue into main with commit f1e828e Mar 17, 2026
18 checks passed
@thomasiles thomasiles deleted the remove-welsh-feature-flag branch March 17, 2026 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants