Skip to content

Add weekly_submission_emails_enabled feature flag#2052

Merged
stephencdaly merged 1 commit into
mainfrom
add-feature-flag-for-weekly-batches
Mar 26, 2026
Merged

Add weekly_submission_emails_enabled feature flag#2052
stephencdaly merged 1 commit into
mainfrom
add-feature-flag-for-weekly-batches

Conversation

@stephencdaly
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/6ebxtzqO

Add weekly_submission_emails_enabled feature flag for forms admin.

Enable on dev and staging. We're enabling on staging as this feature does not affect any end-to-end tests and we want to reliably be able to test this even if people push up work in progress changes to dev.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

Add weekly_submission_emails_enabled feature flag for forms admin.

Enable on dev and staging. We're enabling on staging as this feature
does not affect any end-to-end tests and we want to reliably be able
to test this even if people push up work in progress changes to dev.
Copilot AI review requested due to automatic review settings March 25, 2026 16:46
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a weekly_submission_emails_enabled feature flag to the Forms Admin infrastructure configuration, enabling weekly submission batch emails to be toggled per environment.

Changes:

  • Introduces a new weekly_submission_emails_enabled boolean variable to the forms-admin Terraform module.
  • Wires the flag into the ECS task definition as SETTINGS__FEATURES__WEEKLY_SUBMISSION_EMAILS_ENABLED.
  • Sets the flag to true in dev and staging tfvars (and false elsewhere).

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
infra/modules/forms-admin/variables.tf Adds the new feature-flag input variable.
infra/modules/forms-admin/main.tf Exposes the flag to the running app via ECS environment variable.
infra/deployments/forms/tfvars/dev.tfvars Enables the flag in dev.
infra/deployments/forms/tfvars/staging.tfvars Enables the flag in staging.
infra/deployments/forms/tfvars/user-research.tfvars Sets an explicit false value for schema completeness.
infra/deployments/forms/tfvars/production.tfvars Sets an explicit false value for production.
infra/deployments/forms/inputs.tf Extends forms_admin_settings object type to include the new flag.
infra/deployments/forms/forms-admin/main.tf Passes the new settings value through to the forms-admin module.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@stephencdaly stephencdaly added this pull request to the merge queue Mar 26, 2026
Merged via the queue into main with commit c9e6306 Mar 26, 2026
23 checks passed
@stephencdaly stephencdaly deleted the add-feature-flag-for-weekly-batches branch March 26, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants