Add weekly_submission_emails_enabled feature flag#2052
Merged
Conversation
Add weekly_submission_emails_enabled feature flag for forms admin. Enable on dev and staging. We're enabling on staging as this feature does not affect any end-to-end tests and we want to reliably be able to test this even if people push up work in progress changes to dev.
There was a problem hiding this comment.
Pull request overview
Adds a weekly_submission_emails_enabled feature flag to the Forms Admin infrastructure configuration, enabling weekly submission batch emails to be toggled per environment.
Changes:
- Introduces a new
weekly_submission_emails_enabledboolean variable to theforms-adminTerraform module. - Wires the flag into the ECS task definition as
SETTINGS__FEATURES__WEEKLY_SUBMISSION_EMAILS_ENABLED. - Sets the flag to
trueindevandstagingtfvars (andfalseelsewhere).
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| infra/modules/forms-admin/variables.tf | Adds the new feature-flag input variable. |
| infra/modules/forms-admin/main.tf | Exposes the flag to the running app via ECS environment variable. |
| infra/deployments/forms/tfvars/dev.tfvars | Enables the flag in dev. |
| infra/deployments/forms/tfvars/staging.tfvars | Enables the flag in staging. |
| infra/deployments/forms/tfvars/user-research.tfvars | Sets an explicit false value for schema completeness. |
| infra/deployments/forms/tfvars/production.tfvars | Sets an explicit false value for production. |
| infra/deployments/forms/inputs.tf | Extends forms_admin_settings object type to include the new flag. |
| infra/deployments/forms/forms-admin/main.tf | Passes the new settings value through to the forms-admin module. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
lfdebrux
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/6ebxtzqO
Add weekly_submission_emails_enabled feature flag for forms admin.
Enable on dev and staging. We're enabling on staging as this feature does not affect any end-to-end tests and we want to reliably be able to test this even if people push up work in progress changes to dev.
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully