Add environment variables for One Login#2102
Merged
Merged
Conversation
9afd9ec to
96920eb
Compare
96920eb to
04ddefc
Compare
There was a problem hiding this comment.
Pull request overview
This PR wires GOV.UK One Login configuration into the forms-runner Terraform deployment so each environment can pass the One Login issuer URL plus SSM-backed client credentials into the ECS task.
Changes:
- Added a new
govuk_one_login_base_urlinput through the deployment and module variable chain. - Injected One Login configuration into the
forms-runnerECS task as one plain environment variable and two SSM-backed secrets. - Set per-environment One Login base URLs for dev, staging, user-research, and production.
Reviewed changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
infra/modules/forms-runner/variables.tf |
Declares the new module input for the One Login base URL. |
infra/modules/forms-runner/main.tf |
Passes the new One Login env var and secret references into the ECS service definition. |
infra/deployments/forms/tfvars/user-research.tfvars |
Adds the user-research One Login base URL. |
infra/deployments/forms/tfvars/staging.tfvars |
Adds the staging One Login base URL. |
infra/deployments/forms/tfvars/production.tfvars |
Adds the production One Login base URL. |
infra/deployments/forms/tfvars/dev.tfvars |
Adds the dev One Login base URL. |
infra/deployments/forms/inputs.tf |
Extends the deployment settings object with the new field. |
infra/deployments/forms/forms-runner/main.tf |
Threads the new deployment setting into the forms-runner module call. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
04ddefc to
adb8e02
Compare
alice-carr
approved these changes
May 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/tKtA1VPQ/
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,staging,user-research, and/orprod)apply-forms-terraform-<environment>pipelines have run successfully