Skip to content

Add environment variables for One Login#2102

Merged
stephencdaly merged 2 commits into
mainfrom
add-environment-variables-for-one-login
May 5, 2026
Merged

Add environment variables for One Login#2102
stephencdaly merged 2 commits into
mainfrom
add-environment-variables-for-one-login

Conversation

@stephencdaly
Copy link
Copy Markdown
Contributor

What problem does this pull request solve?

Trello card: https://trello.com/c/tKtA1VPQ/

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

  • Remember to run make <environment> forms/account apply on the relevant environments (dev, staging, user-research, and/or prod)
  • Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

@stephencdaly stephencdaly force-pushed the add-environment-variables-for-one-login branch from 9afd9ec to 96920eb Compare May 5, 2026 11:01
@stephencdaly stephencdaly force-pushed the add-environment-variables-for-one-login branch from 96920eb to 04ddefc Compare May 5, 2026 11:06
@stephencdaly stephencdaly marked this pull request as ready for review May 5, 2026 11:37
Copilot AI review requested due to automatic review settings May 5, 2026 11:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR wires GOV.UK One Login configuration into the forms-runner Terraform deployment so each environment can pass the One Login issuer URL plus SSM-backed client credentials into the ECS task.

Changes:

  • Added a new govuk_one_login_base_url input through the deployment and module variable chain.
  • Injected One Login configuration into the forms-runner ECS task as one plain environment variable and two SSM-backed secrets.
  • Set per-environment One Login base URLs for dev, staging, user-research, and production.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
infra/modules/forms-runner/variables.tf Declares the new module input for the One Login base URL.
infra/modules/forms-runner/main.tf Passes the new One Login env var and secret references into the ECS service definition.
infra/deployments/forms/tfvars/user-research.tfvars Adds the user-research One Login base URL.
infra/deployments/forms/tfvars/staging.tfvars Adds the staging One Login base URL.
infra/deployments/forms/tfvars/production.tfvars Adds the production One Login base URL.
infra/deployments/forms/tfvars/dev.tfvars Adds the dev One Login base URL.
infra/deployments/forms/inputs.tf Extends the deployment settings object with the new field.
infra/deployments/forms/forms-runner/main.tf Threads the new deployment setting into the forms-runner module call.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread infra/modules/forms-runner/main.tf Outdated
Comment thread infra/modules/forms-runner/main.tf
@stephencdaly stephencdaly force-pushed the add-environment-variables-for-one-login branch from 04ddefc to adb8e02 Compare May 5, 2026 11:42
@stephencdaly stephencdaly added this pull request to the merge queue May 5, 2026
Merged via the queue into main with commit b305e39 May 5, 2026
18 checks passed
@stephencdaly stephencdaly deleted the add-environment-variables-for-one-login branch May 5, 2026 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants