BAU: Create data api secrets with correct names

[whi-tw]

What problem does this pull request solve?

Trello card: https://trello.com/c/NKwHyKNP/3100-fix-rds-data-api

Previously, we created our own secrets for the Data API with a custom
name format. The Query Editor Console can find secrets with the name
format rds-db-credentials/cluster-*/<credential-reference>, so if we
create our secrets with that format, this will be a better experience
for engineers using the Query Editor Console.

The Query editor console will automatically create a secret with this
format if someone uses the Add new database credentials option in the
console. We should clean these up, so as not to pollute the credentials
list with potentially outdated secrets. A better long-term solution
would be to prevent engineers from creating secrets in the first place,
but this is a good interim step.

I've also drive-by fixed an annoyance with the specs - happy to move this to a new PR if it's too chunky for this one.

• Create secrets with the correct name format
• Allow engineer access to secrets with the new name format
• Update forms-cli to use the new secrets
• Add a post-apply script to delete any user-created secrets

Testing

You can test in dev where it's currently deployed:

gds aws forms-dev-admin -- forms data_api -c aurora-v2-cluster-forms-runner-dev -d forms-runner -u root -s 'select 1;'
{
  "updated": 0,
  "records": [
    {
      "?column?": 1
    }
  ]
}

gds aws forms-dev-admin -- forms data_api -c aurora-v2-cluster-forms-runner-dev -d forms-runner -s 'select 1;'
{
  "updated": 0,
  "records": [
    {
      "?column?": 1
    }
  ]
}

Reminders

If you've made changes to the deployer role (files in modules/deployer-access):

• Remember to run make <environment> forms/account apply on the relevant environments (dev, staging and/or prod)
• Check the #govuk-forms-deployment-notifications Slack channel to ensure the apply-forms-terraform-<environment> pipelines have run successfully

[cadmiumcat]

This works well and makes more sense 🙌