Add alerts for bounce notifications jobs#2119
Merged
Merged
Conversation
Add an alarm that will fire if the ScheduleBounceNotificationsJob does not run for over a day. If this job does not run, then bounce notifications will not be sent out to group/org admins. Alarm if there are 25 consecutive 1-hour periods with no runs of the ScheduleBounceNotificationsJob. This allows for some flexibility in the schedule in the case of downtime. Alert at info level, meaning that we send an email to the infra test email for dev/staging and to Zendesk for production.
Add alarm that creates a Zendesk ticket in the tech support queue if there are failed executions for the bounce_notifications Solid Queue queue for forms-runner.
There was a problem hiding this comment.
Pull request overview
Adds CloudWatch alarms to improve operational monitoring of bounce-notification background processing in forms-runner, ensuring failures or missing daily scheduling are surfaced (and create Zendesk tickets in production).
Changes:
- Added an alarm that fires if the daily bounce-notifications scheduling job hasn’t run within the expected window.
- Added an alarm that fires when Solid Queue jobs in the
bounce_notificationsqueue have failed and won’t be retried.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| infra/deployments/forms/health/alerts/schedule-bounce-notifications-job-not-run.tf | Adds a “job not run” CloudWatch alarm for ScheduleBounceNotificationsJob using the existing Forms/Jobs Started metric pattern. |
| infra/deployments/forms/health/alerts/failed-bounce-notifications-job-executions.tf | Adds a “failed job executions” CloudWatch alarm for the bounce_notifications Solid Queue queue using the existing FailedJobExecutions pattern. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/WmCipXbC
Add alarms for:
Both alerts will create a Zendesk ticket if they fire in the production environment.
Things to consider when reviewing
Reminders
If you've made changes to the deployer role (files in
modules/deployer-access):make <environment> forms/account applyon the relevant environments (dev,stagingand/orprod)apply-forms-terraform-<environment>pipelines have run successfully