Skip to content

Add rake task to migrate data from old columns in Submissions#1547

Merged
theseanything merged 1 commit into
mainfrom
theseanything/generalise-submission-model
Jul 28, 2025
Merged

Add rake task to migrate data from old columns in Submissions#1547
theseanything merged 1 commit into
mainfrom
theseanything/generalise-submission-model

Conversation

@theseanything
Copy link
Copy Markdown
Contributor

@theseanything theseanything commented Jul 25, 2025

"delivery_status" is to replace "mail_status", and "last_delivery_attempt" is to replace "sent_at". To drop the old column, this adds a rake task to ensure that data in the new columns is in sync with the old columns. After this task is run, we can remove usage and drop the old columns.

DavidBiddle
DavidBiddle previously approved these changes Jul 28, 2025
Copy link
Copy Markdown
Contributor

@DavidBiddle DavidBiddle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Change looks good anyd works for me locally. The new task might benefit from some tests but I think that's optional given that it's a oneoff task we'll be deleting almost immediately.

"delivery_status" is to replace "mail_status" and "last_delivery_attempt" is to replace "sent_at". To drop the old column, this adds a rake task to ensure that data iin the new columns is in sync with old columns. After this task is run, we can remove use and drop the old columns.
@theseanything theseanything force-pushed the theseanything/generalise-submission-model branch from 6e619a5 to 59c8eb9 Compare July 28, 2025 14:26
@theseanything theseanything enabled auto-merge July 28, 2025 14:26
@theseanything theseanything disabled auto-merge July 28, 2025 14:52
@theseanything theseanything force-pushed the theseanything/generalise-submission-model branch from 59c8eb9 to 6887ec1 Compare July 28, 2025 14:58
@sonarqubecloud
Copy link
Copy Markdown

@theseanything theseanything enabled auto-merge July 28, 2025 14:59
@theseanything
Copy link
Copy Markdown
Contributor Author

Change looks good anyd works for me locally. The new task might benefit from some tests but I think that's optional given that it's a oneoff task we'll be deleting almost immediately.

Yeah, I've manually run this and confident this runs as expected - don't think it's worth the effort for adding the tests.

@github-actions
Copy link
Copy Markdown
Contributor

🎉 A review copy of this PR has been deployed! It is made of up two components

  1. A review copy of forms-runner
  2. A production copy of forms-admin

Important

Not all of the functionality of forms-runner is present in review apps.
Functionality such as sending emails, file upload, and S3 submission types are
deliberately disabled for the sake of simplifying review apps.

You should use the full dev environment to test the functionality which is disabled here.

It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready
after 5 minutes, there may be something wrong with the ECS task. You will need to go to the integration AWS account
to debug, or otherwise ask an infrastructure person.

For the sign in details and more information, see the review apps wiki page.

@theseanything theseanything merged commit 1327c92 into main Jul 28, 2025
11 checks passed
@theseanything theseanything deleted the theseanything/generalise-submission-model branch July 28, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants