Add rake task to migrate data from old columns in Submissions#1547
Conversation
DavidBiddle
left a comment
There was a problem hiding this comment.
Change looks good anyd works for me locally. The new task might benefit from some tests but I think that's optional given that it's a oneoff task we'll be deleting almost immediately.
"delivery_status" is to replace "mail_status" and "last_delivery_attempt" is to replace "sent_at". To drop the old column, this adds a rake task to ensure that data iin the new columns is in sync with old columns. After this task is run, we can remove use and drop the old columns.
6e619a5 to
59c8eb9
Compare
59c8eb9 to
6887ec1
Compare
|
Yeah, I've manually run this and confident this runs as expected - don't think it's worth the effort for adding the tests. |
|
🎉 A review copy of this PR has been deployed! It is made of up two components Important Not all of the functionality of forms-runner is present in review apps. You should use the full dev environment to test the functionality which is disabled here. It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |



"delivery_status" is to replace "mail_status", and "last_delivery_attempt" is to replace "sent_at". To drop the old column, this adds a rake task to ensure that data in the new columns is in sync with the old columns. After this task is run, we can remove usage and drop the old columns.