Make confirmation email for Welsh bi-lingual#2083
Conversation
3e1b95c to
550abf4
Compare
stephencdaly
left a comment
There was a problem hiding this comment.
Changes look good, we just need to make sure we're passing in the Welsh support details like we're passing in the Welsh "what happens next"
8cbe7d7 to
36647bc
Compare
stephencdaly
left a comment
There was a problem hiding this comment.
Changes do what we need. I've suggested a few improvements to the tests for the additional logic added for the Welsh support details.
36647bc to
54a55e6
Compare
…ocale We need to send emails that has both English and Welsh for users who answered any submission in Welsh. This means we need to explicitly pass the locale we want to use.
…Welsh Unfortunately have to discard relying on the I18n locale as we are using two languages at this point, whereas I18n will use whatever singular locale is set.
We now need to use the bi-lingual version.
54a55e6 to
7d37989
Compare
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2083.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
What problem does this pull request solve?
When a user answers Welsh questions, the confirmation email now uses a bilingual Notify template. The mailer passes both English and Welsh personalisation variables (_cy variants for submission_date, what_happens_next_text, and support_contact_details) so each language section of the template receives the correct content. Template selection is driven by the explicit submission_locale parameter rather than the ambient I18n locale.
Trello card: https://trello.com/c/NLqWmwvf/2894-update-confirmation-emails-to-cater-for-new-welsh-form-submissions
Things to consider when reviewing