Remove MailerOptions Data object used by confirmation email mailer#2110
Merged
Conversation
This Data object existed before the Submission model existed and was used to pass common data used by the submission and confirmation emails. It is no longer needed, and we can instead pass the Submission and Form objects to the mailer to get the data we need.
stephencdaly
force-pushed
the
remove-mailer-options-data-object
branch
from
db525e7 to
5b41679
Compare
Contributor
|
🎉 A review copy of this PR has been deployed! You can reach it at: https://pr-2110.submit.review.forms.service.gov.uk/ It may take 5 minutes or so for the application to be fully deployed and working. If it still isn't ready For the sign in details and more information, see the review apps wiki page. |
chao-xian
approved these changes
May 19, 2026
Contributor
chao-xian
left a comment
chao-xian
left a comment
There was a problem hiding this comment.
Nice! Ty. Works locally and code changes look good
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/NLqWmwvf
This Data object existed before the Submission model existed and was used to pass common data used by the submission and confirmation emails.
It is no longer needed, and we can instead pass the Submission and Form objects to the mailer to get the data we need.
This means we don't need to pass attributes for all the form attributes that have Welsh translations.
Things to consider when reviewing