Merged
Conversation
peterfajemisincabinetoffice
approved these changes
Feb 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed changes
BAU - Performance Optimisations
What changed
Previously provisioned concurrency was added to facilitate the NFR which had a high number of users per second. This NFR was set too high and did not take into account real world traffic. Whilst this NFR is being adjusted, we are reverting our configuration to save costs.
Updated esbuild as the latest version has some performance optimisations.
Why did it change
Save costs ~$300 per month
Testing
Deployed to Dev and ran a performance test against it