AUT-5136: Connect account-data-api to Authenticator table#7821
Merged
ChristianSoftwire merged 6 commits intomainfrom Feb 20, 2026
Merged
Conversation
…mbdas
- Add read/write/delete policies for the authenticator table
- Reference the relevant policies in the passkeys-{action} lambdas
- Add the encryption keys for the authenticator table
Signed-off-by: Christian Sophocleous <145482922+ChristianSoftwire@users.noreply.github.com>
ChristianSoftwire
force-pushed
the
AUT-5136-connect-account-data-api-to-authenticator-table
branch
2 times, most recently
from
e149194 to
208df91
Compare
- Authenticator is an abstract class that forms the base class for entries in the Authenticator table - The Authenticator abstract class takes a generic parameter. This is because the methods on Authenticator should return the class that inherits from Authenticator, rather than an Authenticator itself - The protected self() method is used by the methods in Authenticator to return the child class rather than Authenticator - Both of the above means that when constructing a Passkey, we can use methods from both the Passkey.class and the Authenticator.class - Partition key is the PublicSubjectId and sort key is the SortKey which will be made of the CredentialType and CredentialId Signed-off-by: Christian Sophocleous <145482922+ChristianSoftwire@users.noreply.github.com>
Signed-off-by: Christian Sophocleous <145482922+ChristianSoftwire@users.noreply.github.com>
Signed-off-by: Christian Sophocleous <145482922+ChristianSoftwire@users.noreply.github.com>
ChristianSoftwire
force-pushed
the
AUT-5136-connect-account-data-api-to-authenticator-table
branch
from
208df91 to
425b50c
Compare
alhcomer
reviewed
Feb 20, 2026
shared/src/main/java/uk/gov/di/authentication/shared/services/BaseDynamoService.java
Show resolved
Hide resolved
alhcomer
reviewed
Feb 20, 2026
...ta-api/src/main/java/uk/gov/di/authentication/accountdata/services/DynamoPasskeyService.java
Outdated
Show resolved
Hide resolved
… within the Authenticator table - This is a specific DynamoPasskeyService, to access Passkey entities - This is needed because Authenticator is abstract and will be inherited from. We can't set up an DynamoAuthenticatorService as we need to know if it's a passkey or another authenticator (for example MFA) Signed-off-by: Christian Sophocleous <145482922+ChristianSoftwire@users.noreply.github.com>
… the GHA pre-merge checks Signed-off-by: Christian Sophocleous <145482922+ChristianSoftwire@users.noreply.github.com>
ChristianSoftwire
force-pushed
the
AUT-5136-connect-account-data-api-to-authenticator-table
branch
from
425b50c to
cb33195
Compare
|
ChristianSoftwire
deleted the
AUT-5136-connect-account-data-api-to-authenticator-table
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
DynamoPasskeyServiceto interact with the DB for passkey entitiesaccount-data-api-integration-testsand add test for theDynamoPasskeyServiceHow to review
Checklist
Co-authored-bylines where pairing or mobbing has taken place