Open
Conversation
cearl1
previously approved these changes
Feb 19, 2026
template.yaml
Outdated
| Threshold: 10 | ||
| EvaluationPeriods: 1 | ||
|
|
||
| SpotRequestQueueSecondLineAlarm: |
Contributor
There was a problem hiding this comment.
Minor nit, but could we move this alarm above the pagerduty one so as you read downwards the alarms get more severe?
template.yaml
Outdated
| - !Ref SlackEvents | ||
| - !Ref SecondLineSlackEvents | ||
| AlarmName: !Sub ${Environment}-spot-request-queue-alarm | ||
| AlarmDescription: !Sub "Age of the oldest message on ${Environment} sqs spot request queue exceeds 10 seconds.ACCOUNT: di-orchestration-${Environment}. Runbook: https://govukverify.atlassian.net/wiki/x/VIFoCAE" |
Contributor
There was a problem hiding this comment.
Another minor nit, could we make this alarm description match the format of the pagerduty one? there's some slight differences
- pagerDutyAlarm - dlq 2ndline alarm - 2ndline alarm
isaac-GDS
force-pushed
the
ATO-2173/spot-request-queue-alarms
branch
from
69d338c to
25a8a37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Wider context of change
Move spot request queue into Orch
What’s changed
Added alarms:
oldest message in the queue for 10 seconds (2nd line)
oldest message in the queue for 60 seconds (pager duty)
message in DLQ (2nd line)
if not in prod then it will go to slack channel
Manual testing
ToDo test in dev