Bau: assert on full audit events in send notification handler tests#8360
Open
BeckaL wants to merge 2 commits into
Open
Bau: assert on full audit events in send notification handler tests#8360BeckaL wants to merge 2 commits into
BeckaL wants to merge 2 commits into
Conversation
Will make it easier to refactor as we'll be able to better judge equivalence when we switch away from setting metadata pairs on the audit context.
BeckaL
force-pushed
the
BAU/send-notification-handler
branch
from
777e75d to
fa1293d
Compare
|
ChristianSoftwire
approved these changes
May 20, 2026
Contributor
ChristianSoftwire
left a comment
ChristianSoftwire
left a comment
There was a problem hiding this comment.
LGTM - thanks for doing that
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Provides a more solid base for refactoring.