ATO-2559: Add feature flag for defaulting tokenAuthMethod#8362
Open
cearl1 wants to merge 4 commits into
Open
Conversation
980b81e to
db1f9a2
Compare
db1f9a2 to
a71cf3d
Compare
Louisasa
approved these changes
May 20, 2026
a71cf3d to
0284f30
Compare
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Wider context of change
We previously allowed for tokenAuthMethod to be null, and treated
private_key_jwtas the default in thePrivateKeyJwtClientAuthValidator. To make it a bit clearer it would be nice to move this defaulting into the client registry getter.What’s changed
This PR adds a feature flag (enabled in dev, build, and staging) to default the tokenAuthMethod to
private_key_jwtif it is null. This is done in a utility class and the method is used in all places where we access the tokenAuthMethod. I also added some tests for the utility class.Checklist
LocalOrchestrationApi.java) or not required.