Skip to content

ATO-2559: Add feature flag for defaulting tokenAuthMethod#8362

Open
cearl1 wants to merge 4 commits into
mainfrom
ATO-2559/feature-flag-for-default-token-auth-method
Open

ATO-2559: Add feature flag for defaulting tokenAuthMethod#8362
cearl1 wants to merge 4 commits into
mainfrom
ATO-2559/feature-flag-for-default-token-auth-method

Conversation

@cearl1
Copy link
Copy Markdown
Contributor

@cearl1 cearl1 commented May 19, 2026

Wider context of change

We previously allowed for tokenAuthMethod to be null, and treated private_key_jwt as the default in the PrivateKeyJwtClientAuthValidator. To make it a bit clearer it would be nice to move this defaulting into the client registry getter.

What’s changed

This PR adds a feature flag (enabled in dev, build, and staging) to default the tokenAuthMethod to private_key_jwt if it is null. This is done in a utility class and the method is used in all places where we access the tokenAuthMethod. I also added some tests for the utility class.

Checklist

  • Lambdas have correct permissions for the resources they're accessing.
  • Impact on orch and auth mutual dependencies has been checked.
  • Changes have been made to contract tests or not required.
  • Changes have been made to the simulator or not required.
  • Changes have been made to stubs or not required.
  • Successfully deployed to authdev or not required.
  • Successfully run Authentication acceptance tests against sandpit or not required.
  • Added new endpoints to local running (LocalOrchestrationApi.java) or not required.

@cearl1 cearl1 requested review from a team as code owners May 19, 2026 15:11
@cearl1 cearl1 force-pushed the ATO-2559/feature-flag-for-default-token-auth-method branch from 980b81e to db1f9a2 Compare May 19, 2026 15:13
@cearl1 cearl1 force-pushed the ATO-2559/feature-flag-for-default-token-auth-method branch from db1f9a2 to a71cf3d Compare May 20, 2026 09:01
@cearl1 cearl1 force-pushed the ATO-2559/feature-flag-for-default-token-auth-method branch from a71cf3d to 0284f30 Compare May 20, 2026 09:26
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants