AUT-4297: Add mobile channel#2791
Closed
alhcomer wants to merge 11 commits into
Closed
Conversation
alhcomer
force-pushed
the
AUT-4297/add-mobile-channel
branch
from
5aa8000 to
dd3418e
Compare
GHSwallow
reviewed
May 19, 2025
GHSwallow
reviewed
May 19, 2025
alhcomer
force-pushed
the
AUT-4297/add-mobile-channel
branch
4 times, most recently
from
227ef63 to
ed01176
Compare
alhcomer
force-pushed
the
AUT-4297/add-mobile-channel
branch
from
f05b4ea to
1a7c947
Compare
alhcomer
force-pushed
the
AUT-4297/add-mobile-channel
branch
from
1a7c947 to
0c1e1e1
Compare
GHSwallow
reviewed
May 22, 2025
GHSwallow
left a comment
GHSwallow
left a comment
Contributor
There was a problem hiding this comment.
looking good! Just some musings
alhcomer
force-pushed
the
AUT-4297/add-mobile-channel
branch
from
0c1e1e1 to
e53f85b
Compare
GHSwallow
reviewed
May 27, 2025
Accept 'generic_app' as a valid channel on the FE and render the same mobile pages as the strategic app when res.locals.genericApp is true. Have added an isApp res.locals param that is true if genericApp or strategicApp is true. This value is then used in templates.
- When genericApp is true content is now the same in base.njk as when strategicAppChannel is true. If either is true res.locals.isApp is set to true, passed to template and used as a conditional.
- res.locals.isApp is true if channel is generic_app or strategic_app
- Also deleted explicitly passed params to res.render.
- - These are not needed as res.locals are inherently passed to the
template by res.render
- If res.locals.strategicApp or res.locals.genericApp res.locals.isApp is set to true - This is then passed to mfa-reset-with-ipv templates as a conditional for content. This ensures the same app content is shown for both strategic app and generic app channels.
- If res.locals.strategicApp or res.locals.genericApp are true, res.locals.isApp is set to true - This is then passed to account created templates as a conditional for content. This ensures the same app content is shown for both strategic app and generic app channels. - The channel is set in the channel middleware when orch handover to auth.
- If res.locals.strategicApp or res.locals.genericApp are true, res.locals.isApp is set to true - This is then passed to error handler templates as a conditional for content. This ensures the same app content is shown for both strategic app and generic app channels. - The channel is set in the channel middleware when orch handover to auth. - Also deleted unnecessary explicit params passed to res.render. res.render inherently uses res.locals values when rendering templates.
- If res.locals.strategicApp or res.locals.genericApp are true, res.locals.isApp is set to true - This is then passed to sec code error templates as a conditional for content. This ensures the same app content is shown for both strategic app and generic app channels. - The channel is set in the channel middleware when orch handover to auth. - Also deleted unnecessary explicit params passed to res.render. res.render inherently uses res.locals values when rendering templates.
- res.locals.isApp is set to true if the channel is generic_app or strategic_app
- The tests weren't able to run locally without the imports despite running successfully in GHA - Also deleted unnecessary res.locals.strategicAppChannel assignment
alhcomer
force-pushed
the
AUT-4297/add-mobile-channel
branch
from
e53f85b to
5c0c5b7
Compare
|
GHSwallow
approved these changes
May 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accept 'generic_app' as a valid channel on the FE and render the same pages and content as the strategic app when res.locals.genericApp is true. This is done by referencing the new res.locals.isApp parameter in templates, which is true when either of the aforementioned res.locals params are true.
How to review
Checklist
Related PRs