Skip to content

Aut 4248/check your phone sms sms#2794

Merged
alhcomer merged 11 commits into
mainfrom
AUT-4248/check-your-phone-sms-sms
May 28, 2025
Merged

Aut 4248/check your phone sms sms#2794
alhcomer merged 11 commits into
mainfrom
AUT-4248/check-your-phone-sms-sms

Conversation

@alhcomer

@alhcomer alhcomer commented May 19, 2025 •
edited
Loading

Copy link
Copy Markdown
Contributor

What

  • Assigns a defaultMfaMethodId on a user's session from enter-password onwards
  • When a user selects a radio option on the how do you want to get security codes? page, defaultMfaMethodId on the session is updated with the user's choice
  • NEED TO REQUEST OTP AFTER MAKING NEW CHOICE
  • This is then passed to the enter-mfa controller. The MFA ID here is used to retrieve the MFA's associated number on the session to show on the enter-mfa screen.
  • When the SMS MFA code is send to the BE, we are now also sending the defaultMfaMethodId. This is so that we know which MFA method to validate the code against

How to review

Checklist

  • Performance analyst has been notified of the change.
  • A UCD review has been performed.
  • Documentation has been updated to reflect these changes.

Related PRs

@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch 20 times, most recently from 78982ff to 06a700c Compare May 23, 2025 12:19
@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch 2 times, most recently from 14fae25 to f366137 Compare May 27, 2025 12:12
@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch 4 times, most recently from 022db74 to 8930c45 Compare May 27, 2025 14:23
@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch 2 times, most recently from 7a30c20 to d9e5b3d Compare May 28, 2025 08:15
@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch from d9e5b3d to 08245d3 Compare May 28, 2025 08:54
alhcomer added 10 commits May 28, 2025 12:20
@alhcomer
AUT-4248: Implement howDoYouWantSecurityCodesPost for SMS user
c936a53 
- If user has chosen SMS method, redirects them to ENTER_MFA
- Saves the chosen SMS method ID to the session
- This will be used to show the correct number on the enter MFA screen
@alhcomer
AUT-4248: Assign defaultMfaMethodId at user log in
8e23687 
- Uses req.session.user.mfaMethods data to assign ID to defaultMfaMethodId
- This ensures it is populated whenever the variable is referenced later on
@alhcomer
AUT-4248: get defaultMfaMethodId in enter-mfa-controller
2a1f7c6 
- If coming from the how do you want security codes screen, defaultMfaMethodId

wip to squash into enter mfa
@alhcomer
AUT-4248: Send defaultMfaMethodId to VerifyCodeHandler on BE
ee0b3c6 
- This is so that the MFA code is sent to the correct number
@alhcomer
AUT-4248: Send mfa method ID when requesting MFA
b21d67a
@alhcomer
AUT-4248: Send redactedPhoneNumber to template in resend mfa
1ca7469
@alhcomer
AUT-4248: Send activeMfaMethodId in send-mfa-controller
518d63c
@alhcomer
AUT-4248: call sendMfaCode with retrieved activeMfaMethod
2d7a7a4 
- Retrieve and set activeMfaMethodId to that of default mfa method

wip to squash
@alhcomer
BAU: refactor reset password check email tests
68f72ca 
- Delete redundant test
- - The assertions in this test are covered in "should render reset password check email view"
- Refactor overlapping tests into single parameterized test
- Add missing assertion
@alhcomer
AUT-4248: fix last reset-password-check-email auth app integration test
8d87b16
@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch from 41ec30d to d80776e Compare May 28, 2025 11:35
@alhcomer alhcomer force-pushed the AUT-4248/check-your-phone-sms-sms branch from d80776e to ae08377 Compare May 28, 2025 11:41
@alhcomer alhcomer marked this pull request as ready for review May 28, 2025 11:41
@alhcomer alhcomer requested review from a team as code owners May 28, 2025 11:41
@sonarqubecloud

sonarqubecloud Bot commented May 28, 2025

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
96.8% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@alhcomer alhcomer merged commit 2b4662e into main May 28, 2025
11 checks passed
@alhcomer alhcomer deleted the AUT-4248/check-your-phone-sms-sms branch May 28, 2025 12:35
@mattvot mattvot mentioned this pull request May 28, 2025
Closed
@alhcomer alhcomer restored the AUT-4248/check-your-phone-sms-sms branch May 28, 2025 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mattvot mattvot mattvot approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@alhcomer @mattvot