Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
56 commits
Select commit Hold shift + click to select a range
c22e2c5
OLH-3720 Set up Change Phone Number page to match new Figma designs
jeremy-barrass-gov Jan 29, 2026
1bd5e5b
OLH-3720 Add content for No UK Phone Number page
jeremy-barrass-gov Jan 30, 2026
e8ab67d
OLH-3720 Fix translation file, add template filters
jeremy-barrass-gov Jan 30, 2026
0868b60
OLH-3720 Add query paramter type=changePhoneNumber to new page
jeremy-barrass-gov Jan 30, 2026
54d88c9
OLH-3720 Get passing unit tests
jeremy-barrass-gov Jan 30, 2026
a064a30
OLH-3720 Update with latest main
jeremy-barrass-gov Feb 2, 2026
936f98c
OLH-3720 Add integration tests, one test failing
jeremy-barrass-gov Feb 3, 2026
ed74c96
OLH-3720 Fix legacy integration tests, add playwright feature
jeremy-barrass-gov Feb 3, 2026
a59ad04
OLH-3720 Add passing integration tests
jeremy-barrass-gov Feb 5, 2026
ad9f0ce
OLH-3720 merge latest main, fix merge conflicts
jeremy-barrass-gov Feb 5, 2026
06fd667
OLH-3720 Add Welsh to translations, update integration test packages
jeremy-barrass-gov Feb 5, 2026
3f2d3e4
OLH-3720 Fix package vulnerabilities
jeremy-barrass-gov Feb 5, 2026
c4c3f90
OLH-3720 Fix step in feature tests
jeremy-barrass-gov Feb 5, 2026
a99e3e5
OLH-3720 Address PR comments from Dana
jeremy-barrass-gov Feb 6, 2026
9cc5c0d
OLH-3720 Update redirect in Change Phone Number Controller
jeremy-barrass-gov Feb 6, 2026
223de35
OLH-3720 Remove copy javascript from copy-scripts
jeremy-barrass-gov Feb 6, 2026
abf92af
OLH-3720 Remove copy dist/public/scripts from copy-scripts
jeremy-barrass-gov Feb 6, 2026
ac81850
OLH-3720 Fix testing actions
jeremy-barrass-gov Feb 6, 2026
393830b
OLH-3720 Remove trailing comma
jeremy-barrass-gov Feb 6, 2026
a586a96
OLH-3720 Fix integration tests
jeremy-barrass-gov Feb 6, 2026
e96b1b3
Merge pull request #2731 from govuk-one-login/OLH-3720-update-mobile-…
jeremy-barrass-gov Feb 6, 2026
37f3896
OLH-3718 Add No UK mobile phone link to change default method
jeremy-barrass-gov Feb 6, 2026
b024ebf
OLH-3720 Add unit tests for no uk phone number page variants
jeremy-barrass-gov Feb 9, 2026
10ae018
OLH-3718 Merge latest main, fix merge conflicts
jeremy-barrass-gov Feb 10, 2026
2d7e118
OLH-3720 Adjust implementation of reading request origin
jeremy-barrass-gov Feb 10, 2026
51fcf2d
OLH-3720 Fix all unit tests for change uk phone number controller
jeremy-barrass-gov Feb 10, 2026
e6ad3d7
OLH-3720 Add integ test for no UK Phone number with Authenticator backup
jeremy-barrass-gov Feb 10, 2026
342c98d
OLH-3720 Pass feature tests for no UK mobile phone variants
jeremy-barrass-gov Feb 11, 2026
790d391
OLH-3722 Add no UK mobile phone journey type, TDD v3
jeremy-barrass-gov Feb 11, 2026
b5cb0eb
OLH-3722 Create set state utility
jeremy-barrass-gov Feb 13, 2026
cf6e730
OLH-3722 Add unit test for exisitng target state
jeremy-barrass-gov Feb 16, 2026
236a101
OLH-3722 Fix unit tests properly
jeremy-barrass-gov Feb 16, 2026
9c756f7
OLH-3722 Add getNextState expectation back into test
jeremy-barrass-gov Feb 16, 2026
c56596f
OLH-3722 Update target state for controllers still giving redirect loop
jeremy-barrass-gov Feb 17, 2026
4b75e5e
OLH-3718 Update with latest main
jeremy-barrass-gov Feb 17, 2026
9380e8b
OLH-3722 Routing for /no-uk-mobile-phone page working correctly
jeremy-barrass-gov Feb 17, 2026
8facfa4
OLH-3722 & OLH-3723 Update change default method and add backup journeys
jeremy-barrass-gov Feb 19, 2026
4e04f9c
OLH-3723 Update Error messages and Welsh translations
jeremy-barrass-gov Feb 19, 2026
4c9e0db
OLH-3723 Feature tests for Add Backup SMS MFA with SMS as default pass
jeremy-barrass-gov Feb 19, 2026
215f15d
OLH-3723 Marge latest main, fix merge conflicts
jeremy-barrass-gov Feb 19, 2026
f94d6ec
OLH-3723 Add feature tests
jeremy-barrass-gov Feb 20, 2026
1745bdf
OLH-3718 Fix bugs and code smells from Sonar Qube
jeremy-barrass-gov Feb 20, 2026
cb514fe
OLH-3718 Improve code coverage of Set State uitlity
jeremy-barrass-gov Feb 20, 2026
c55f3db
OLH-3718 Fix legacy integration test
jeremy-barrass-gov Feb 20, 2026
99533f0
OLH-3718 Fix all legacy integration tests for change phone number
jeremy-barrass-gov Feb 20, 2026
de6c8c9
OLH-3718 Fix linting errors
jeremy-barrass-gov Feb 20, 2026
7d042b5
OLH-3718 merge latest main, fix merge conflicts
jeremy-barrass-gov Feb 23, 2026
0505c35
OLH-3718 Address content mismatches
jeremy-barrass-gov Feb 24, 2026
00e2eac
OLH-3718 merge latest main, fix merge conflicts
jeremy-barrass-gov Feb 24, 2026
2ac0195
OLH-3718 Fix feature test step
jeremy-barrass-gov Feb 24, 2026
22c089d
OLH-3718 Fix next feature test step
jeremy-barrass-gov Feb 24, 2026
b7b62cb
OLH-3718 Remove errant comma
jeremy-barrass-gov Feb 24, 2026
f7ecae3
OLH-3718 Fix errant 'Cancel and go' button content in feature tests
jeremy-barrass-gov Feb 24, 2026
c1f139e
OLH-3718 Final integration test fix, I hope
jeremy-barrass-gov Feb 24, 2026
983220f
OLH-3718 Address PR comments and final UCD change
jeremy-barrass-gov Feb 24, 2026
c2d47e0
OLH-3718 Tidy up HTML classes, fix Welsh
jeremy-barrass-gov Feb 24, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
132 changes: 132 additions & 0 deletions integration-tests/tests/features/@add-backup-method.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,132 @@
Feature: Add Backup SMS MFA Method

@failMobile
Scenario: Add Backup SMS MFA with SMS as Default
Given I go to the "Root" page
And I sign in as the "userDEFAULTSms" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Add a back-up method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Add a back-up method"
And I can see two radio buttons
And I can see a collapsed detail block "What is an authenticator app"
Given I click the detail block "What is an authenticator app"
Then I can see the explanation details "An authenticator app creates a security code that helps confirm it’s you when you sign in."
Given I select "UK mobile phone number" and click the "continue" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
Given I enter and submit my new mobile phone number "07890123456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Check your phone"
And I am shown a message confirming a code has been sent to my new phone number ending "3456"
Given I enter and submit the code "123456" sent to my new mobile number ending "3456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "You’ve added a back-up method for getting security codes"
And I am shown a message confirming that I have added a backup method
And I am shown a message confirming I can receive codes on my backup SMS number ending "3456"
And I can see the "Back to Security" button

@failMobile
Scenario: Add Backup SMS MFA with SMS as Default no UK mobile number
Given I go to the "Root" page
And I sign in as the "userDEFAULTSms" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Add a back-up method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Add a back-up method"
And I can see two radio buttons
And I can see a collapsed detail block "What is an authenticator app"
Given I click the detail block "What is an authenticator app"
Then I can see the explanation details "An authenticator app creates a security code that helps confirm it’s you when you sign in."
Given I select "UK mobile phone number" and click the "continue" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
And I can see a collapsed detail block "I do not have a UK mobile phone number"
Given I click the detail block "I do not have a UK mobile phone number"
Then I can see an explanation and link to start this journey again
Given I click the "Go back to choose authenticator app" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Add a back-up method"
And I can see two radio buttons
And I have an option to select Authenticator App

@failMobile
Scenario: Add Backup SMS with Authenticator App as Default
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthApp" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Add a back-up method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Add a back-up method"
And I can see the "Add a UK mobile phone number" button
Given I click the "Add a UK mobile phone number" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
Given I enter and submit my new mobile phone number "07890123456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Check your phone"
And I am shown a message confirming a code has been sent to my new phone number ending "3456"
Given I enter and submit the code "123456" sent to my new mobile number ending "3456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "You’ve added a back-up method for getting security codes"
And I am shown a message confirming that I have added a backup method
And I am shown a message confirming I can receive codes on my backup SMS number ending "3456"
And I can see the "Back to Security" button

@failMobile
Scenario: Add Backup SMS with Authenticator App as Default no UK mobile number
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthApp" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Add a back-up method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Add a back-up method"
And I can see the "Add a UK mobile phone number" button
And I can see a collapsed detail block "I do not have a UK mobile phone number"
Given I click the detail block "I do not have a UK mobile phone number"
Then I can see the explanation details "To get security codes by text message you must use a UK mobile phone number."
And I can see the explanation details "As you already use an authenticator app to get security codes, you cannot add another one as a back-up method."
Given I click the "Cancel and go back to security" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
172 changes: 172 additions & 0 deletions integration-tests/tests/features/@change-default-method.feature
Original file line number Diff line number Diff line change
@@ -0,0 +1,172 @@
Feature: Change Default MFA Method From Authenticator App

@failMobile
Scenario: Change Default Method with no SMS backup
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthApp" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Use a different default method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Use a different default method"
Given I click the "Add a UK mobile phone number" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
Given I enter and submit my new mobile phone number "07890123456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Check your phone"
And I am shown a message confirming a code has been sent to my new phone number ending "3456"
Given I enter and submit the code "123456" sent to my new mobile number ending "3456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "You’ve changed your default method for getting security codes"
And I am shown a message confirming that my Default Method has been changed
# The following step is disabled pending fixing the stubs to return the correct data.
# And I am shown a message confirming security codes will be sent to my phone number ending "3456"


@failMobile
Scenario: Change Default Method with no SMS Backup leaving at Use a different default method screen
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthApp" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Use a different default method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Use a different default method"
Given I click the "I do not have a UK mobile phone number" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "If you do not have a UK mobile phone number"
And I am shown a message explaining what I can do
And I am shown a message explaining how to change to a different authenticator app
And there is a "Go back to Security" button

@failMobile
Scenario: Change Default Method with no SMS Backup leaving at Enter your UK mobile phone number screen
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthApp" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Use a different default method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Use a different default method"
Given I click the "Add a UK mobile phone number" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
Given I click the "I do not have a UK mobile phone number" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "If you do not have a UK mobile phone number"
And I am shown a message explaining what I can do
And I am shown a message explaining how to change to a different authenticator app
And there is a "Go back to Security" button

@failMobile
Scenario: Change Default Method with SMS Backup
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthAppBackupSms" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Use a different default method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Use a different default method"
Given I click the "Add a UK mobile phone number" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
Given I enter and submit my new mobile phone number "07890123456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Check your phone"
And I am shown a message confirming a code has been sent to my new phone number ending "3456"
Given I enter and submit the code "123456" sent to my new mobile number ending "3456"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "You’ve changed your default method for getting security codes"
And I am shown a message confirming that my Default Method has been changed
# The following step is disabled pending fixing the stubs to return the correct data.
# And I am shown a message confirming security codes will be sent to my phone number ending "3456"

@failMobile
Scenario: Change Default Method with SMS Backup leaving at Use a different default method screen
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthAppBackupSms" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Use a different default method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Use a different default method"
Given I click the "I do not have a UK mobile phone number" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "If you do not have a UK mobile phone number"
And I am shown a message explaining what I can do
And I am shown a message explaining how to change to a different authenticator app
And there is a "Go back to Security" button

@failMobile
Scenario: Change Default Method with SMS Backup leaving at Enter your UK mobile phone number screen
Given I go to the "Root" page
And I sign in as the "userDEFAULTAuthAppBackupSms" user
And I go to the "Security" page
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Security"
Given I click the "Use a different default method" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your password"
Given I enter and submit my password "f4kePa55wo2d?!"
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Use a different default method"
Given I click the "Add a UK mobile phone number" button
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "Enter your UK mobile phone number"
Given I click the "I do not have a UK mobile phone number" link
And the page has finished loading
Then the page meets our accessibility standards
And the page title is prefixed with "If you do not have a UK mobile phone number"
And I am shown a message explaining what I can do
And I am shown a message explaining how to change to a different authenticator app
And there is a "Go back to Security" button
Loading
Loading