Skip to content

PYIC-8667: Switch dev environments to AppConfig pipeline. #3482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
undermad merged 16 commits into from
Oct 10, 2025
Merged

PYIC-8667: Switch dev environments to AppConfig pipeline. #3482

undermad merged 16 commits into from
Oct 10, 2025

Conversation

@undermad
Copy link
Contributor

@undermad undermad commented Oct 7, 2025 •
edited
Loading

Proposed changes

What changed

  • core-back template
    • Added condition for AppConfig env variables to point to the new resource when in dev environment
    • Changed resources to be allowed to access any AppConfig (*)
    • Added validation lambda permission to be invoked by any AppConfig
    • Conditionally create old App Config resources to exclude them from dev environments

Why did it change

  • To switch dev environments to App Config Pipelines

Issue tracking

Other PRs:

Checklists

  • READMEs and documentation up-to-date
  • API/ unit/ contract tests have been written/ updated
  • No risk of exposure: PII, credentials, etc through logs/ code
  • Production changes appropriately staged out

undermad added 16 commits October 1, 2025 23:05
@undermad
PYIC-8667: Add AppConfigValidate permission
d7c75b8
@undermad
PYIC-8667: Add wildcard app config permission for all resources.
94b1562
@undermad
PYIC-8667: Add environment variable condition for config env and prof…
3064ef6 
…ile ids to point to new app config
@undermad
PYIC-8667: Add s3 bucket for app config pipeline.
fd9c770
@undermad
PYIC-8667: Add s3 bucket name
bd1b973
@undermad
PYIC-8667: Add KMS to template
7b58f20
@undermad
PYIC-8667: Fix naming and GitHubSourceBucketPolicy
cf507fd
@undermad
PYIC-8667: Add app config pipeline resources outputs.
6467017
@undermad
PYIC-8667: Allow root to sign
23997e9
@undermad
PYIC-8667: Add kms arn to ssm
5813571
@undermad
PYIC-8667: Adjust naming for app config resources
826ac1c
@undermad
PYIC-8667: Add retention for s3 bucket.
5e98b21
@undermad
PYIC-8667: Move shared dev resources creation to ipv-core-common-infr…
010d949 
…a repo
@undermad
PYIC-8667: Bring back outputs.
bd618f4
@undermad
PYIC-8667: Remove condition from ValidateAppConfigInvokePermission
ed9afdd
@undermad
PYIC-8667: Bring back condition for old app config.
f2989af
@undermad undermad requested review from a team as code owners October 7, 2025 14:33
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@undermad undermad merged commit 5b9ab90 into main Oct 10, 2025
9 checks passed
@undermad undermad deleted the pyic-8667 branch October 10, 2025 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeyp blakeyp blakeyp approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@undermad @blakeyp