BAU: Add DT trace id to logs #2011
Conversation
| sessionId: req.session?.id, | ||
| }); | ||
| next(); | ||
| }); |
There was a problem hiding this comment.
Not sure where this came from:
- We seem to do this twice - once on everything (above) and once on the router only, but it's identical
- The pino-http middleware already sets
req.logfor us
If there's a good reason then happy to keep it...
There was a problem hiding this comment.
Git says you're the one who added both those blocks... so I think it's up to you to say whether there's a reason.
Is there a reason this PR is still a draft?
There was a problem hiding this comment.
I suspect they appeared via a merge conflict but I'm not sure - happy to say we only need one, and perhaps that should be extracted to a separate PR.
This specific PR is still in draft because we've been directed not to tie ourselves into Dynatrace-specific libraries. Ideally we'd use OpenTelemetry instead (as an open standard) but I couldn't get that to work.
Fine to close this if you're not missing the functionality!
Joe-Edwards-GDS
force-pushed
the
bau-dt-trace-id
branch
from
35af07d to
93dd5d0
Compare
|
Proposed changes
What changed
Why did it change