Skip to content

PYIC-8790: Add progress spinner #2443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
AmritSidhu wants to merge 5 commits into
base: main
Choose a base branch
from
Open

PYIC-8790: Add progress spinner #2443

AmritSidhu wants to merge 5 commits into from

Conversation

@AmritSidhu
Copy link
Contributor

@AmritSidhu AmritSidhu commented Dec 8, 2025 •
edited by atlassian bot
Loading

Proposed changes

What changed

  • Replace 'Continue...' button with progress spinner component on 'page-ipv-success' and 'page-ipv-reuse' pages
  • Default content and translations are already built in to the component. The component is actually a link masquerading as a button (it takes an href) so we’ll need to use our journey GET mechanism to simulate a ‘next’ event.

Why did it change

  • To ensure we can handle any potential latency / wait time gracefully this story is to replace the current Continue to service button on those two pages with a progress button component that shows a dynamic ‘waiting’ progress element.

Issue tracking

Checklists

  • READMEs and documentation up-to-date
  • Browser/ unit/ Selenium tests have been written/ updated
  • No risk of exposure: PII, credentials, etc through logs/ code
  • Ensure added/updated routes have CSRF protection if required

@AmritSidhu AmritSidhu requested review from a team as code owners December 8, 2025 12:04
@AmritSidhu AmritSidhu force-pushed the pyic-8790 branch 3 times, most recently from 0b701c5 to f293b10 Compare December 8, 2025 12:07
@AmritSidhu
PYIC-8790: Add progress spinner
34914f8 
To ensure we can handle any potential latency / wait time gracefully this story is to replace the current Continue to service button on those two pages with a progress button component that shows a dynamic ‘waiting’ progress element.
blakeyp
blakeyp previously approved these changes Dec 8, 2025
View reviewed changes
Copy link
Contributor

@blakeyp blakeyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but hold merge until QA complete in dev

blakeyp
blakeyp previously approved these changes Dec 11, 2025
View reviewed changes
@AmritSidhu
PYIC-8790: add static unrecoverable PYI technical error route to bypa…
61ac24b 
…ss journey validation and support frontend-ui timeout handling
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 11, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@blakeyp blakeyp blakeyp left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@AmritSidhu @blakeyp