Skip to content

OJ-3197 - Create NINo check handler#629

Merged
barnabycollins merged 6 commits into
mainfrom
OJ-3197
Jul 2, 2025
Merged

OJ-3197 - Create NINo check handler#629
barnabycollins merged 6 commits into
mainfrom
OJ-3197

Conversation

@barnabycollins
Copy link
Copy Markdown
Contributor

@barnabycollins barnabycollins commented Jun 12, 2025

Proposed changes

What changed

  • New Lambda function written for NINo checking
  • Some minor additions to lambdas/common
  • /check-test endpoint added to NINo check API Gateway for testing purposes
  • Unit tests for new function and utility function changes
  • Integration tests added for new function

Why did it change

Step functions have been shown to have unsatisfactory performance, and are hard to test, debug and observe. Given that the NINo check logic is on a user's critical path to verifying their identity, we intend to replace the step functions with TypeScript Lambdas.

What's left to do (in other tickets)

  • OJ-3201: Implement and test handling of multiple attempts, and retries (should be a small job)
  • OJ-3202: Switch over APIGW /check endpoint to point to the Lambda; spin down step function resources & delete unused code

Issue tracking

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

Other considerations

  • Update README with any new instructions or tasks

Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/helpers/get-session-info.ts Outdated
Comment thread lambdas/nino-check/src/helpers/validate-nino.ts Outdated
Comment thread lambdas/nino-check/src/helpers/validate-nino.ts Outdated
Comment thread lambdas/nino-check/src/helpers/validate-nino.ts Outdated
Comment thread lambdas/nino-check/src/helpers/validate-nino.ts Outdated
Comment thread infrastructure/template.yaml
Comment thread lambdas/common/src/database/exceptions/errors.ts Outdated
Comment thread lambdas/common/src/database/get-record-by-session-id.ts Outdated
Comment thread lambdas/nino-check/package.json
Comment thread lambdas/nino-check/src/handler.ts Outdated
Comment thread lambdas/nino-check/src/helpers/add-auth-code-to-session.ts
Comment thread lambdas/nino-check/src/helpers/audit.ts
Comment thread lambdas/nino-check/src/helpers/function-config.ts Outdated
Comment thread lambdas/nino-check/src/helpers/retrieve-attempts.ts Outdated
Comment thread lambdas/nino-check/src/hmrc-apis/pdv.ts
Comment thread lambdas/nino-check/src/hmrc-apis/pdv.ts Outdated
Comment thread package.json
Comment thread lambdas/common/src/database/util/is-record-expired.ts Outdated
Comment thread lambdas/common/src/database/get-record-by-session-id.ts Outdated
Comment thread lambdas/nino-check/src/hmrc-apis/pdv.ts
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 2, 2025

Copy link
Copy Markdown
Contributor

@Caitlin-cooling Caitlin-cooling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A mammoth effort Barnaby! Looks really good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants