Skip to content

OJ-3227 - Implement initial issue-credential function#648

Merged
mikebeeby merged 4 commits into
mainfrom
OJ-3227
Jul 17, 2025
Merged

OJ-3227 - Implement initial issue-credential function#648
mikebeeby merged 4 commits into
mainfrom
OJ-3227

Conversation

@barnabycollins
Copy link
Copy Markdown
Contributor

@barnabycollins barnabycollins commented Jul 8, 2025 •
edited
Loading

Proposed changes

What changed

  • Added credential issuer function

Questions

  • Is it within scope to be emitting metrics for this ticket? If so, which ones?

Why did it change

We are looking to move NINo check backend logic to Lambdas instead of step functions

Issue tracking

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

Other considerations

  • Update README with any new instructions or tasks

@barnabycollins barnabycollins force-pushed the OJ-3227 branch 2 times, most recently from 3781af2 to 7bd7b47 Compare July 8, 2025 14:33
jkunle
jkunle reviewed Jul 9, 2025
View reviewed changes
Comment thread lambdas/issue-credential/src/handler.ts Outdated
jkunle
jkunle reviewed Jul 14, 2025
View reviewed changes
Comment thread lambdas/common/tests/config/function-config.test.ts Outdated
Caitlin-cooling
Caitlin-cooling reviewed Jul 15, 2025
View reviewed changes
Comment thread infrastructure/template.yaml
Caitlin-cooling
Caitlin-cooling reviewed Jul 15, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@Caitlin-cooling Caitlin-cooling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing major!

Comment thread infrastructure/template.yaml Outdated
Comment thread lambdas/issue-credential/src/helpers/retrieve-nino-user.ts Outdated
Comment thread lambdas/issue-credential/src/helpers/retrieve-session.ts Outdated
Comment thread lambdas/issue-credential/src/helpers/retrieve-session.ts Outdated
Comment thread lambdas/issue-credential/src/helpers/retrieve-session.ts Outdated
Comment thread lambdas/issue-credential/src/types/input.ts Outdated
Comment thread infrastructure/public-api.yaml Outdated
@mikebeeby
OJ-3227: Query access token index
82135f8 
When using the QueryCommand on the Session Table we need to query using the partion key (sessionId), not the accessToken.

Refactored to use the access-token-index to initially retrieve the sessionId, and added retries for this given recent issues with GSIs. Then query the Session Table with the sessionId. This is the same as the existing State machine.

Note: TTL does not need checking on the access-token-index. When we query the Session table with the sessionId it will check the TTL.
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Jul 16, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mikebeeby mikebeeby mikebeeby left review comments

+2 more reviewers

@jkunle jkunle jkunle left review comments

@Caitlin-cooling Caitlin-cooling Caitlin-cooling approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@barnabycollins @jkunle @Caitlin-cooling @mikebeeby