OJ-3227 - Improvements to common code

[barnabycollins]

Proposed changes

What changed

• Changed db functions to perform TTL filtering in the data layer
  • Simplifies application code, unit tests & error handling
  • Might marginally improve performance 👀
• Moved various utilities from nino-check to common, ready for the issue-credential function
• Improved error logging by making safeStringifyError log the full String(error) when outside prod
  • This should make troubleshooting significantly easier when looking into unexpected 500s outside prod
  • This requires that we explicitly set LOG_FULL_ERROR=true in the environment variables, so it should not accidentally get switched on in prod
  • If not set, we still log Error.name / typeof error as before
• Refactored function config classes to extend a bass class to avoid repetition for common config (audit, table names)

Why did it change

These improvements make the code more maintainable, and will provide a solid foundation for the issue-credential Lambda work.

Issue tracking

• OJ-3197
• OJ-3227

Checklists

Environment variables or secrets

• Documented in the README
• Added to deployment repository
• Added to local startup repository

Other considerations

• Update README with any new instructions or tasks

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud