Skip to content

Conversation

@barnabycollins
Copy link
Contributor

@barnabycollins barnabycollins commented Jan 13, 2026

Proposed changes

What changed

  • Moved a number of utilities for getting information from the nino-check function into the common directory
  • Added optional AbortSignal parameter to these utilities so they can be cancelled if they time out during the healthcheck
  • Implemented healthcheck handler which asserts that the following are behaving as expected:
    • SSM param fetch
    • HMRC host
    • OTG token endpoint
    • PDV API
  • Wrote IaC for healthcheck function and attached it to the public APIGW

Info endpoint response looks like this:

{
  "hmrcConfig": {
    "result": {
      "otg": {
        "apiUrl": "https://p2vx5z0kf7-vpce-05d20d011acdf9002.execute-api.eu-west-2.amazonaws.com/dev/token?tokenType=stub"
      },
      "pdv": {
        "apiUrl": "https://n7cz9mydma.execute-api.eu-west-2.amazonaws.com/dev/individuals/authentication/authenticator/api/match"
      }
    },
    "latency": 125
  },
  "hmrcHost": { "result": { "status": 403 }, "latency": 71 },
  "otg": { "result": { "tokenLength": 9 }, "latency": 163 },
  "pdv": { "result": { "status": 401 }, "latency": 68 }
}

Why did it change

  • We want to be able to easily verify the integrity of the Check HMRC CRI's external dependencies

Issue tracking

Checklists

Environment variables or secrets

  • No environment variables or secrets were added or changed

Other considerations

  • Update README with any new instructions or tasks

surajkumar
surajkumar previously approved these changes Jan 14, 2026
Copy link
Member

@surajkumar surajkumar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - can you just add what the output of the /info looks like?

@barnabycollins
Copy link
Contributor Author

LGTM - can you just add what the output of the /info looks like?

@surajkumar - added to PR description

surajkumar
surajkumar previously approved these changes Jan 14, 2026
@sonarqubecloud
Copy link

@barnabycollins barnabycollins merged commit 6a1efda into main Jan 14, 2026
11 checks passed
@barnabycollins barnabycollins deleted the OJ-3387 branch January 14, 2026 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants