OJ-3546: Update Experian Response Timeouts #615

MarieseMikely · 2026-01-13T15:51:21Z

Proposed changes

What changed

Added custom timeout exception class to handle timeout implementation
Configured HTTPConduit found here within the IdentityIQWebServiceSoapCache get method with 28 seconds so that if timeout occurs it can be caught in the getQuestions and submitAnswer method.
Changed the method of the responses from private to protected so that it can be used for unit tests
Added try-catch method so that when request is sent and we’re waiting for the response, if it hits the timeoutException, a new timeout metric will be sent to CW and error logs will be displayed, if it hits any other exception the error handling should continue as is, or successful should continue as normal.
Added timeout scenario to the integration tests based on the newly created scenario.
Updated timeout handling within the question and questionAnswer lambdas

Why did it change

Occasionally the Question and Answer lambdas time out due to the question and answer requests to Experian taking >29 seconds. This means the error is not actually handled as the lambda errors/fails.

Issue tracking

OJ-3546

Checklists

Environment variables or secrets

No environment variables or secrets were added or changed

Other considerations

Update README with any new instructions or tasks

… included metric and logs

…ementation

mikebeeby · 2026-01-15T16:22:28Z

lib/src/main/java/uk/gov/di/ipv/cri/kbv/api/gateway/KBVGateway.java


 public class KBVGateway {
    private static final Logger LOGGER = LogManager.getLogger();
+    private static final int RESPONSE_TIMEOUT = 24000;


Could we do more than 24 seconds?

Yeah, the reason why I set it to 24s was because of this "this will need to be set to slightly less than 25-28 seconds" in the ticket - should it be 25s or over?

Oh ok, lets go with 28 seconds actually. We can reduce it if we still see lambda timeouts.

mikebeeby · 2026-01-15T16:23:05Z

lib/src/main/java/uk/gov/di/ipv/cri/kbv/api/gateway/KBVGateway.java

+        } catch (Exception e) {
+            LOGGER.error("Question retrieval to the third party API threw an exception", e);
+            metricsService.sendErrorMetric(EXPERIAN_INITIAL_QUESTION_ERROR, "EXCEPTION");
+            return null;


Just to clarify, what happens if null is returned here?

When going back to the Question handler null will be the response in either the getQuestions here: return this.kbvService.getQuestions(identityIQWebServiceSoap, questionRequest); which should end up going to this throw new QuestionNotFoundException("No questions available"); since null is returned

I've updated it now to throw the timeout at the start if the questionResponse is null, rather than going through the lambda to another error message.

mikebeeby · 2026-01-15T16:24:39Z

lib/src/main/java/uk/gov/di/ipv/cri/kbv/api/gateway/KBVGateway.java

            IdentityIQWebServiceSoap identityIQWebServiceSoap, SAARequest saaRequest) {
-        return identityIQWebServiceSoap.saa(saaRequest);
+
+        implementTimeout(identityIQWebServiceSoap);


Did you look at adding this here: https://github.com/govuk-one-login/ipv-cri-kbv-api/blob/main/lib/src/main/java/uk/gov/di/ipv/cri/kbv/api/service/IdentityIQWebServiceSoapCache.java

This does the retrieval from the soap service, so I guess I can add the timeout implementation in the IdentityIQWebServiceSoapCache file preventing me from adding this implementTimeout method to two places (both the getQuestions and submitAnswers).

I've moved the method and updated the unit tests for the IdentityIQWebServiceSoapCache file

…ions

…vice based on GH comments with associated tests

…on to stop earlier when response is null

…and update gateway file

sonarqubecloud · 2026-01-16T16:55:18Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
82.2% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

MarieseMikely added 2 commits January 13, 2026 15:50

OJ-3546: feat added timeout implementation to gateway and service and…

eb5dbb6

… included metric and logs

OJ-3546: feat - updated test and added scenarios for the timeout impl…

96cc18f

…ementation

MarieseMikely changed the title ~~Oj 3546~~ OJ-3546: Update Experian Response Timeouts Jan 13, 2026

MarieseMikely temporarily deployed to development January 13, 2026 15:55 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to di-ipv-cri-dev January 13, 2026 15:59 — with GitHub Actions Inactive

OJ-3546: fix - refactor method to prevent duplication

8a0aab9

MarieseMikely temporarily deployed to development January 13, 2026 17:16 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to di-ipv-cri-dev January 13, 2026 17:18 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to development January 13, 2026 21:51 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to di-ipv-cri-dev January 13, 2026 21:53 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to development January 14, 2026 10:41 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to di-ipv-cri-dev January 14, 2026 10:43 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to development January 14, 2026 10:47 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to di-ipv-cri-dev January 14, 2026 10:49 — with GitHub Actions Inactive

MarieseMikely force-pushed the OJ-3546 branch from 845e1e5 to bbeff6a Compare January 14, 2026 11:20

MarieseMikely temporarily deployed to development January 14, 2026 11:22 — with GitHub Actions Inactive

MarieseMikely temporarily deployed to di-ipv-cri-dev January 14, 2026 11:24 — with GitHub Actions Inactive

MarieseMikely marked this pull request as ready for review January 14, 2026 11:24

MarieseMikely requested review from a team as code owners January 14, 2026 11:24

mikebeeby reviewed Jan 15, 2026

View reviewed changes

MarieseMikely temporarily deployed to development January 16, 2026 14:53 — with GitHub Actions Inactive

MarieseMikely had a problem deploying to di-ipv-cri-dev January 16, 2026 14:57 — with GitHub Actions Failure

MarieseMikely temporarily deployed to development January 16, 2026 15:55 — with GitHub Actions Inactive

MarieseMikely had a problem deploying to di-ipv-cri-dev January 16, 2026 15:59 — with GitHub Actions Failure

MarieseMikely temporarily deployed to development January 16, 2026 16:21 — with GitHub Actions Inactive

MarieseMikely had a problem deploying to di-ipv-cri-dev January 16, 2026 16:22 — with GitHub Actions Failure

MarieseMikely added 4 commits January 16, 2026 16:28

OJ-3546: fix - added unit tests for timeout implementation and except…

796d26d

…ions

OJ-3546: fix - remove timeout implementation from gateway to soap ser…

a84c54a

…vice based on GH comments with associated tests

OJ-3546: fix - added timeout exception within handler for the executi…

c88c892

…on to stop earlier when response is null

OJ-3546: chore - removed throwable cause from timeout exception file …

0bfc52e

…and update gateway file

MarieseMikely force-pushed the OJ-3546 branch from 3fd02ec to 2ea7204 Compare January 16, 2026 16:33

MarieseMikely temporarily deployed to development January 16, 2026 16:34 — with GitHub Actions Inactive

MarieseMikely had a problem deploying to di-ipv-cri-dev January 16, 2026 16:36 — with GitHub Actions Failure

OJ-3546: feat - add timeout integration test within unhappy feature file

4067e12

MarieseMikely force-pushed the OJ-3546 branch from 2ea7204 to 4067e12 Compare January 16, 2026 16:51

MarieseMikely deployed to development January 16, 2026 16:52 — with GitHub Actions View deployment

MarieseMikely deployed to di-ipv-cri-dev January 16, 2026 16:54 — with GitHub Actions Active

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

OJ-3546: Update Experian Response Timeouts #615

OJ-3546: Update Experian Response Timeouts #615

Uh oh!

MarieseMikely commented Jan 13, 2026 •

edited

Loading

Uh oh!

mikebeeby Jan 15, 2026

Uh oh!

MarieseMikely Jan 15, 2026

Uh oh!

mikebeeby Jan 15, 2026

Uh oh!

mikebeeby Jan 15, 2026

Uh oh!

MarieseMikely Jan 16, 2026

Uh oh!

MarieseMikely Jan 16, 2026

Uh oh!

mikebeeby Jan 15, 2026

Uh oh!

MarieseMikely Jan 16, 2026 •

edited

Loading

Uh oh!

MarieseMikely Jan 16, 2026

Uh oh!

sonarqubecloud bot commented Jan 16, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

OJ-3546: Update Experian Response Timeouts #615

Are you sure you want to change the base?

OJ-3546: Update Experian Response Timeouts #615

Uh oh!

Conversation

MarieseMikely commented Jan 13, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

What changed

Why did it change

Issue tracking

Checklists

Environment variables or secrets

Other considerations

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

MarieseMikely Jan 16, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

sonarqubecloud bot commented Jan 16, 2026

Quality Gate passed

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

MarieseMikely commented Jan 13, 2026 •

edited

Loading

MarieseMikely Jan 16, 2026 •

edited

Loading