Conversation
ChrisBates1
force-pushed
the
LIME-2122
branch
2 times, most recently
from
7a69fe3 to
2860c41
Compare
| permissions: | ||
| contents: read | ||
| steps: | ||
| - name: Checkout |
There was a problem hiding this comment.
Can we use the shared action like the other jobs here please, instead of checkout and node-setup?
You can see it done in unit tests:
- name: Setup Node
uses: govuk-one-login/github-actions/node/install-dependencies@4c76410195b5fcb1804fc7c183ed20704252830f
Might be worth thinking about concurrency here as well like other jobs.
There was a problem hiding this comment.
thanks Jess, updated the infra-tests to use the same node setup as the unit-tests
Is it worth at a point setting up a action for the node-setup if we are using it several times through the same workflow and other workflows?
There was a problem hiding this comment.
I don't think so personally - you'd have to call it the same number of times either way, it just means we would have one place to update the version.
I think its used three times, but we don't bother defining other actions that are called a similar number of times separately.
ChrisBates1
force-pushed
the
LIME-2122
branch
8 times, most recently
from
28163ef to
7b3e245
Compare
Added tests for the public-api, private-api and template. Added tests to ensure Canary Alarms, LambdaErrors Alarms and APIGW5XXErrors Alarms are covered
|
3 participants
Added tests for the public-api, private-api and template
Updated the pr-check.yml workflow to include the infra tests
Proposed changes
What changed
Added new tests to cover the validation of the CloudFormation Templates for the BE
Why did it change
To ensure we adhere to best practices within our templates, including structure, resources defaults etc
Issue tracking
Other considerations
Readme.md updated with command to execute infra tests