Skip to content

refactor: update select doc package structure#258

Merged
JacksonJ2W merged 9 commits into
mainfrom
refactor/DCMAW-8798-second-attempt
Apr 7, 2025
Merged

refactor: update select doc package structure#258
JacksonJ2W merged 9 commits into
mainfrom
refactor/DCMAW-8798-second-attempt

Conversation

@JacksonJ2W
Copy link
Copy Markdown
Contributor

@JacksonJ2W JacksonJ2W commented Apr 1, 2025 •
edited
Loading

DCMAW-8798: refactor packages

  • Split each document type into select and confirmation sub-packages
  • Rename stuff relevant to both select and confirmation from SelectDocument... to SelectDoc...

Checklist

  • Check against acceptance criteria
  • Add automated tests
  • Self-review code

@JacksonJ2W JacksonJ2W marked this pull request as ready for review April 1, 2025 16:08
@JacksonJ2W JacksonJ2W requested review from a team as code owners April 1, 2025 16:08
@JacksonJ2W JacksonJ2W mentioned this pull request Apr 1, 2025
Closed
3 tasks
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 1, 2025 •
edited
Loading

Analytics test report is available to download.

@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch 3 times, most recently from 77a0b02 to 3c5e942 Compare April 3, 2025 10:43
jonnyandrew
jonnyandrew approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread .../uk/gov/onelogin/criorchestrator/features/selectdoc/internalapi/nav/SelectDocDestinations.kt
Comment thread ...ov/onelogin/criorchestrator/features/selectdoc/internal/brp/confirmation/ConfirmBrpScreen.kt Outdated
@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from 3c5e942 to 1233ac6 Compare April 4, 2025 15:38
@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from 1233ac6 to ca874f5 Compare April 7, 2025 11:28
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.5% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JacksonJ2W JacksonJ2W merged commit 0c6cace into main Apr 7, 2025
10 checks passed
@JacksonJ2W JacksonJ2W deleted the refactor/DCMAW-8798-second-attempt branch April 7, 2025 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnyandrew jonnyandrew jonnyandrew approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JacksonJ2W @jonnyandrew