Skip to content

feat: confirmation passport screens#259

Merged
JacksonJ2W merged 56 commits into
mainfrom
feat/DCMAW-8798-confirmation-passport-screens
Apr 7, 2025
Merged

feat: confirmation passport screens#259
JacksonJ2W merged 56 commits into
mainfrom
feat/DCMAW-8798-confirmation-passport-screens

Conversation

@JacksonJ2W
Copy link
Copy Markdown
Contributor

@JacksonJ2W JacksonJ2W commented Apr 1, 2025 •
edited
Loading

DCMAW-8798: Confirmation Passport Screens

  • Add and implement ConfirmPassportScreens
  • Create id-check-wrapper module to launch ID Check SDK
  • Add tests

Evidence of the change

AC 1
AC1 and AC4 video evidence
Screenshot 2025-04-03 at 14 14 48
AC 4
AC1 and AC4 video evidence
Screenshot 2025-04-03 at 14 29 09
AC 5
AC5 video evidence

AC8 updated with to correct extra spacing between text and image - other behaviour unchanged.

AC8 Light Dark
En image image
Cy image image
AC 9
image
AC 10
AC10 video evidence
image

Checklist

  • Check against acceptance criteria
  • Add automated tests
  • Self-review code

@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch from 66b65a2 to 261eb4a Compare April 1, 2025 16:26
@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from ef41c0b to a19a588 Compare April 2, 2025 08:30
@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch 2 times, most recently from 43910f1 to 1641fb4 Compare April 2, 2025 09:25
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 2, 2025 •
edited
Loading

Analytics test report is available to download.

@JacksonJ2W JacksonJ2W marked this pull request as ready for review April 2, 2025 11:07
@JacksonJ2W JacksonJ2W requested review from a team as code owners April 2, 2025 11:07
jonnyandrew
jonnyandrew reviewed Apr 2, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few minor comments!

Comment thread .../kotlin/uk/gov/onelogin/criorchestrator/features/idcheckwrapper/internal/SyncSdkViewModel.kt Outdated
Comment thread ...ain/kotlin/uk/gov/onelogin/criorchestrator/features/idcheckwrapper/internal/SyncSdkScreen.kt
Comment thread .../kotlin/uk/gov/onelogin/criorchestrator/features/idcheckwrapper/internal/SyncSdkViewModel.kt Outdated
Comment thread ...ov/onelogin/criorchestrator/features/selectdoc/internal/analytics/ConfirmDocumentScreenId.kt Outdated
Comment thread ...n/criorchestrator/features/selectdoc/internal/passport/confirmation/ConfirmPassportScreen.kt Outdated
Comment thread settings.gradle.kts Outdated
Comment thread ...in/uk/gov/onelogin/criorchestrator/features/session/internal/network/InMemorySessionStore.kt Outdated
@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from 75567d4 to 77a0b02 Compare April 2, 2025 16:15
@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch from d2c6e5a to 3bd8726 Compare April 3, 2025 09:30
@jonnyandrew jonnyandrew mentioned this pull request Apr 3, 2025
Merged
3 tasks
jonnyandrew added a commit that referenced this pull request Apr 3, 2025
@jonnyandrew
fix: Update design system library to fix text styles (#263)
0f0718b 
- Update design system library
- Remove hardcoded text styles for default text

DCMAW-8798

- govuk-one-login/mobile-android-ui#248
- #259 (comment)
@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from 77a0b02 to 3c5e942 Compare April 3, 2025 10:43
@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch from ed898db to bdb6c1b Compare April 3, 2025 10:58
emanuel-gds
emanuel-gds reviewed Apr 3, 2025
View reviewed changes
Comment thread features/select-doc/internal/build.gradle.kts
@SmithaGeetha-hub
Copy link
Copy Markdown

SmithaGeetha-hub commented Apr 3, 2025

Hi @JacksonJ2W The Unit test are missing in this PR. Could you please add them as well. Thanks!
Screenshot 2025-04-03 at 18 07 13

jonnyandrew
jonnyandrew approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown
Contributor

@jonnyandrew jonnyandrew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes!

@JacksonJ2W
Copy link
Copy Markdown
Contributor Author

JacksonJ2W commented Apr 4, 2025

Hi @JacksonJ2W The Unit test are missing in this PR. Could you please add them as well. Thanks! Screenshot 2025-04-03 at 18 07 13

This module is just a placeholder module so far - since all the logic there so far is placeholder logic, we can just rely on the screenshot tests for this placeholder screen

SmithaGeetha-hub
SmithaGeetha-hub approved these changes Apr 4, 2025
View reviewed changes
Copy link
Copy Markdown

@SmithaGeetha-hub SmithaGeetha-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @JacksonJ2W This ticket is approved by QA.

@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from 3c5e942 to 1233ac6 Compare April 4, 2025 15:38
@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch 2 times, most recently from 0aa663a to b6f1e82 Compare April 4, 2025 16:21
@JacksonJ2W JacksonJ2W force-pushed the refactor/DCMAW-8798-second-attempt branch from 1233ac6 to ca874f5 Compare April 7, 2025 11:28
@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch 2 times, most recently from fb7a653 to 49aa6e0 Compare April 7, 2025 13:05
JacksonJ2W added 26 commits April 7, 2025 16:15
@JacksonJ2W
fix: add keep annotation to document variety enum
8937aeb
@JacksonJ2W
chore: tidy up build gradle files
62146dc
@JacksonJ2W
refactor: remove empty values xml files
af5ac01
@JacksonJ2W
chore: tidy up version catalog
1c65e92
@JacksonJ2W
refactor: navigate using DocumentVariety instead of DocumentType
8a7cc84
@JacksonJ2W
refactor: change syncSdk to syncIdCheck
67a6c33
@JacksonJ2W
refactor: combine raw ids for analytics
a3e9ce4
@JacksonJ2W
test: replace screenshots
60d0a17
@JacksonJ2W
refactor: remove settings gradle code enabling local SDK published pa…
123f0b7 
…ckages as repo
@JacksonJ2W
refactor: put InMemorySessionStore in data package
2e3e453
@JacksonJ2W
docs: add code comments for syncIdCheckViewModel
269e2ef
@JacksonJ2W
refactor: put InMemorySessionStoreTest in data package
846f408
@JacksonJ2W
test: add missing screenshot for confirm brp
0b5a7b1
@JacksonJ2W
refactor: tidy up and revert unnecessary changes
74e3a8f
@JacksonJ2W
docs: document SyncIdCheckScreen
089c5be
@JacksonJ2W
test: rerecord screenshots due to UI fix
9c577ba
@JacksonJ2W
refactor: remove unnecessary font size declaration
4e70c27
@JacksonJ2W
refactor: remove SyncIdCheckViewModel unnecessary code
3caad6c
@JacksonJ2W
fix: spacing between text and image
8b4f8aa
@JacksonJ2W
fix: linting
800f1e0
@JacksonJ2W
test: rerecord screenshots
a969ac3
@JacksonJ2W
fix: rebase issues
2a80442
@JacksonJ2W
refactor: rename confirmation to confirm
13cb725
@JacksonJ2W
fix: rebase issues
181dc7c
@JacksonJ2W
fix: address PR comments
76e63df
@JacksonJ2W
fix: test failing because of unconsumed event
693a9ba
@JacksonJ2W JacksonJ2W force-pushed the feat/DCMAW-8798-confirmation-passport-screens branch from 5597d9f to 693a9ba Compare April 7, 2025 15:16
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
51.1% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@JacksonJ2W JacksonJ2W merged commit 97b844d into main Apr 7, 2025
10 checks passed
@JacksonJ2W JacksonJ2W deleted the feat/DCMAW-8798-confirmation-passport-screens branch April 7, 2025 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jonnyandrew jonnyandrew jonnyandrew approved these changes

@emanuel-gds emanuel-gds emanuel-gds approved these changes

@SmithaGeetha-hub SmithaGeetha-hub SmithaGeetha-hub approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@JacksonJ2W @SmithaGeetha-hub @jonnyandrew @emanuel-gds