Skip to content

fix: resolve selected option bug in Select Driving Licence screen#274

Merged
de1phine merged 1 commit into
mainfrom
fix/DCMAW-8099-option-remains-selected-on-back-press
Apr 7, 2025
Merged

fix: resolve selected option bug in Select Driving Licence screen#274
de1phine merged 1 commit into
mainfrom
fix/DCMAW-8099-option-remains-selected-on-back-press

Conversation

@de1phine
Copy link
Copy Markdown
Contributor

@de1phine de1phine commented Apr 7, 2025

DCMAW-8099: title of change

  • Replace remember with rememberSaveable to ensure an option remains selected when a user clicks the confirm button and then the back button to return to the Select Driving Licence Screen

Evidence of the change

English NFC Enabled
Light Mode
Dark Mode

English NFC Not Enabled
Light Mode
Dark Mode

Welsh NFC Enabled
Light Mode
Dark Mode

Welsh NFC Not Enabled
Light Mode
Dark Mode

Checklist

  • Check against acceptance criteria
  • Add automated tests
  • Self-review code

- add `rememberSaveable` to fix issue with option not remaining
  selected when users presses the back button to return to the
  `Select Driving Licence` screen

Resolves: DCMAW-8099
@de1phine de1phine requested review from a team as code owners April 7, 2025 16:29
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 7, 2025

Analytics test report is available to download.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 7, 2025

@SmithaGeetha-hub
Copy link
Copy Markdown

Hi @de1phine Shall we check the previous selection remains selected while clicking back button in this screen? It is not selected in the attached video evidence but I can confirm that it was working as expected in the staging earlier. Thanks !
image

@SmithaGeetha-hub
Copy link
Copy Markdown

This is verified. Thanks!

Copy link
Copy Markdown

@SmithaGeetha-hub SmithaGeetha-hub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@de1phine This is verified and approved. Thanks!

@de1phine de1phine merged commit 2b31dcc into main Apr 7, 2025
12 checks passed
@de1phine de1phine deleted the fix/DCMAW-8099-option-remains-selected-on-back-press branch April 7, 2025 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants