Skip to content

feat: Add custom back handler for FullScreenDialogue#254

Merged
BiancaMihaila merged 4 commits into
mainfrom
feat/DCMAW-12057-local-auth
Apr 10, 2025
Merged

feat: Add custom back handler for FullScreenDialogue#254
BiancaMihaila merged 4 commits into
mainfrom
feat/DCMAW-12057-local-auth

Conversation

@BiancaMihaila
Copy link
Copy Markdown
Contributor

# Add custom back handler for FullScreenDialogue

  • When using the FullScreenDialogue in the LocalAuthImplementation - we require custom back behaviour. Based on the FullScreenDialogue implementation it looks like the dismiss is always required which would technically have the same behaviour as pressing the device back button. We have talked about this in MP and overall the back button behaviour would always align with the dismiss - however, please do raise any potential issues if there are cases/ situations I might have missed/ not account for - This should not be a breaking change as it's not changing the API, rather than assigning the onDismissRequest to the BackHandler

Evidence of the change

No evidence to show - check code

Checklist

Before creating the pull request

  • Commit messages that conform to conventional commit messages.
  • Tests pass locally.
  • Pull request has a clear title with a short description about the feature or update.

Before the CODEOWNERS review the pull request

  • Self-review code.
  • Successfully run changes on a testing device.
  • Complete automated Testing:
    • Unit Tests.
    • Integration Tests.
    • Instrumentation / Emulator Tests.
  • Handle PR comments.

Before merging the pull request

@BiancaMihaila BiancaMihaila force-pushed the feat/DCMAW-12057-local-auth branch from 215c490 to 107c1de Compare April 10, 2025 08:42
@BiancaMihaila BiancaMihaila marked this pull request as ready for review April 10, 2025 08:43
@BiancaMihaila BiancaMihaila requested review from a team as code owners April 10, 2025 08:43
…ault

- provide a nullable lambda that if null, it will keep the befault back button,
else it will use the provided custom on back behaviour
@sonarqubecloud
Copy link
Copy Markdown

@BiancaMihaila BiancaMihaila merged commit e408acc into main Apr 10, 2025
3 checks passed
@BiancaMihaila BiancaMihaila deleted the feat/DCMAW-12057-local-auth branch April 10, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants