feat: Add custom back handler for FullScreenDialogue#254
Merged
Conversation
215c490 to
107c1de
Compare
…ault - provide a nullable lambda that if null, it will keep the befault back button, else it will use the provided custom on back behaviour
|
alex-bradbury-gds
approved these changes
Apr 10, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



# Add custom back handler for
FullScreenDialogueFullScreenDialoguein theLocalAuthImplementation- we require custom back behaviour. Based on the FullScreenDialogue implementation it looks like the dismiss is always required which would technically have the same behaviour as pressing the device back button. We have talked about this in MP and overall the back button behaviour would always align with the dismiss - however, please do raise any potential issues if there are cases/ situations I might have missed/ not account for - This should not be a breaking change as it's not changing the API, rather than assigning theonDismissRequestto theBackHandlerEvidence of the change
No evidence to show - check code
Checklist
Before creating the pull request
Before the CODEOWNERS review the pull request
Before merging the pull request