Skip to content

feat: Enhance keyboard scroll modifier (bringIntoView) to support different list types#421

Merged
jonnyandrew merged 3 commits into
mainfrom
jonny/bring-into-view
Apr 28, 2026
Merged

feat: Enhance keyboard scroll modifier (bringIntoView) to support different list types#421
jonnyandrew merged 3 commits into
mainfrom
jonny/bring-into-view

Conversation

@jonnyandrew
Copy link
Copy Markdown
Contributor

@jonnyandrew jonnyandrew commented Apr 28, 2026

Changes

  • Enhance keyboard scroll modifier (bringIntoView) to support different types of ScrollableState:
    • ScrollState
    • LazyListState
  • Move the modifier into uk.gov.android.ui.patterns.utils.scroll
  • Remove the old modifier

Context

DCMAW-19031

Evidence of the change

Verified manually in test wrapper app:

Screen_recording_20260428_130819.webm

Added automated tests: b8ade63

Checklist

Before creating the pull request

  • Commit messages that conform to conventional commit messages.
  • Ran the app locally ensuring it builds.
  • Tests pass locally.
  • Pull request has a clear title with a short description about the feature or update.
  • Created a draft pull request if it's not ready for review.

Before the CODEOWNERS review the pull request

  • Complete all Acceptance Criteria within Jira ticket.
  • Self-review code.
  • Successfully run changes on a testing device.
  • Complete automated Testing:
    • Unit Tests.
    • Integration Tests.
    • Instrumentation / Emulator Tests.
  • Review Accessibility considerations.
  • Handle PR comments.

Before merging the pull request

@BiancaMihaila BiancaMihaila force-pushed the jonny/bring-into-view branch from c5b707a to 72fd54e Compare April 28, 2026 11:03
@BiancaMihaila BiancaMihaila marked this pull request as ready for review April 28, 2026 11:19
@BiancaMihaila BiancaMihaila requested review from a team as code owners April 28, 2026 11:19
@sonarqubecloud
Copy link
Copy Markdown

@jonnyandrew jonnyandrew merged commit 92af674 into main Apr 28, 2026
3 checks passed
@jonnyandrew jonnyandrew deleted the jonny/bring-into-view branch April 28, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants