DCMAW-11654: investigating github actions#451
Conversation
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
3 times, most recently
from
9136f86 to
20edfed
Compare
| aws-region: eu-west-2 | ||
| role-to-assume: ${{ secrets.GH_ACTIONS_ROLE_ARN }} | ||
|
|
||
| # - name: Cache SAM builds |
|
|
||
| - name: Run unit, infra, and pact tests | ||
| run: npm run test | ||
| # output the file the unit tests generates for use in sonar quality gate |
There was a problem hiding this comment.
DCMAW-11675: Can we output the results from the unit tests for use in the sonar checks
|
|
||
| dev-post-merge: | ||
| name: Dev Post Merge | ||
| needs: sonarqube-scan |
There was a problem hiding this comment.
DCMAW-11675: Does this need dependence on sonar?
| @@ -0,0 +1,60 @@ | |||
| name: Post Merge | |||
There was a problem hiding this comment.
Not completely convinced we need this middleman workflow but I like how simple it makes the backend-api-post-merge and test-resources-post-merge yamls
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
2 times, most recently
from
3eaf0ae to
4d22d78
Compare
| run: npm run test | ||
| # output the file the unit tests generates for use in sonar quality gate | ||
|
|
||
| - name: Generate proxy open api spec |
There was a problem hiding this comment.
Do we need this?
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
12 times, most recently
from
957fd49 to
c49f03d
Compare
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
from
c49f03d to
1d315f5
Compare
|
|
||
| # - name: Generate proxy open api spec | ||
| # if: ${{ inputs.GENERATE_PROXY_OPEN_API_SPEC }} | ||
| # run: npm run generate-proxy-open-api |
There was a problem hiding this comment.
is this needed?
| - name: Set up Homebrew | ||
| if: ${{ inputs.VERIFY_TEMPLATE_RAIN }} | ||
| id: set-up-homebrew | ||
| uses: Homebrew/actions/setup-homebrew@a7a36215df86859f163fbb774ebe0cecf9ec8547 |
There was a problem hiding this comment.
https://github.com/actions/runner-images/blob/main/images/ubuntu/Ubuntu2404-Readme.md#homebrew-note
Brew is already present and the suggested method of using it for these runners is to update path.
Unfortunately the command suggested in the docs doesn't persist across steps. You could run it on every step that uses brew, or uses a program installed by brew (since the changes in path are required to find the installed programs). In the changes to async-infra i found out what the suggested script does and manually updated the path through GITHUB_ENV to persist across steps.
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
4 times, most recently
from
ff5b95a to
4a6e73f
Compare
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
9 times, most recently
from
a9466a3 to
2c1ccc5
Compare
kikidawson-gds
force-pushed
the
DCMAW-11654
branch
from
2c1ccc5 to
c91f9e1
Compare
2 participants
DCMAW-11654
What changed
This is an investigation into standardising github action workflows.
sam validate --lintis to be used overcfn-lintbecause it's already included in the ubuntu version. We can still provide custom rules for cfn-lint in config file when using sam.Why did it change
Checklists