Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: 📒 Files selected for processing (21)
📝 WalkthroughWalkthroughThis pull request systematically removes LoRA adapter support from video generation across the OpenVINO GenAI framework. The changes eliminate sample programs, CMake build rules, public API methods and fields, implementation code, test suites, and documentation references to LoRA adapters in video generation, while updating guidance toward INT8 model usage. Changes
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~22 minutes Poem
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Pull request overview
This PR reverts prior work that added LoRA adapter support to the LTX (text-to-video) pipeline, removing the associated C++/Python API surface, tests, docs, and samples.
Changes:
- Remove LoRA adapter plumbing from the video-generation C++ pipeline/model code paths.
- Remove Python bindings/stubs that exposed video-generation LoRA configuration and methods.
- Delete LoRA text-to-video samples/tests and update documentation to no longer claim video-generation LoRA support.
Reviewed changes
Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| tests/python_tests/test_video_generation.py | Removes LoRA-related video-generation tests. |
| tests/python_tests/samples/test_lora_text2video.py | Deletes LoRA text-to-video sample test. |
| tests/python_tests/samples/conftest.py | Removes LoRA test artifact download mapping. |
| src/python/py_video_generation_pipelines.cpp | Removes VideoGenerationConfig.adapters exposure in pybind. |
| src/python/py_video_generation_models.cpp | Removes LTXVideoTransformer3DModel.set_adapters binding. |
| src/python/openvino_genai/py_openvino_genai.pyi | Updates Python stubs to drop video-generation adapter API. |
| src/cpp/src/video_generation/models/ltx_video_transformer_3d_model.cpp | Disables adapters at compile-time for video transformer. |
| src/cpp/src/video_generation/ltx_pipeline.hpp | Removes adapter propagation/application in video pipeline. |
| src/cpp/src/video_generation/generation_config_utils.cpp | Stops reading adapters into VideoGenerationConfig. |
| src/cpp/src/lora/names_mapping.hpp | Removes detect_lora_prefix declaration (used by reverted code). |
| src/cpp/src/lora/adapter.cpp | Removes detect_lora_prefix implementation. |
| src/cpp/include/openvino/genai/video_generation/ltx_video_transformer_3d_model.hpp | Removes set_adapters API and adapter-related members. |
| src/cpp/include/openvino/genai/video_generation/generation_config.hpp | Removes adapters from VideoGenerationConfig. |
| src/cpp/include/openvino/genai/lora_adapter.hpp | Removes friend/forward decl related to detect_lora_prefix. |
| site/docs/use-cases/video-generation/_sections/_usage_options/index.mdx | Removes LoRA-adapters section from video generation docs. |
| site/docs/guides/lora-adapters.mdx | Removes claim that LoRA is supported for video generation. |
| samples/python/video_generation/lora_text2video.py | Deletes Python LoRA text-to-video sample. |
| samples/python/video_generation/README.md | Removes LoRA sample docs; updates conversion instructions to INT8 example. |
| samples/cpp/video_generation/lora_text2video.cpp | Deletes C++ LoRA text-to-video sample. |
| samples/cpp/video_generation/README.md | Removes LoRA sample docs; updates conversion instructions to INT8 example. |
| samples/cpp/video_generation/CMakeLists.txt | Stops building/installing the LoRA video sample binary. |
You can also share your feedback on Copilot code review. Take the survey.
| adapters->set_tensor_name_prefix(m_lora_prefix); | ||
| m_adapter_controller = AdapterController(m_model, *adapters, device); | ||
| } | ||
| OPENVINO_ASSERT(!adapters, "Adapters are not currently supported for Video Generation Pipeline."); |
Reverts #27
Summary by CodeRabbit
Removed Features
Documentation
Tests