Skip to content

Revert "Fix lora video support"#28

Merged
goyaladitya05 merged 1 commit intomasterfrom
revert-27-fix-lora-video-support
Mar 18, 2026
Merged

Revert "Fix lora video support"#28
goyaladitya05 merged 1 commit intomasterfrom
revert-27-fix-lora-video-support

Conversation

@goyaladitya05
Copy link
Owner

@goyaladitya05 goyaladitya05 commented Mar 18, 2026

Reverts #27

Summary by CodeRabbit

  • Removed Features

    • Removed LoRA adapter support from video generation pipeline.
    • Removed LoRA-based video generation samples.
  • Documentation

    • Updated video generation guides to reflect INT8 model usage.
    • Removed LoRA adapter documentation and examples.
  • Tests

    • Removed LoRA adapter test suite for video generation.

@coderabbitai
Copy link

coderabbitai bot commented Mar 18, 2026

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro

Run ID: 69fa1319-579f-4c03-a60d-6c9808ad2bcf

📥 Commits

Reviewing files that changed from the base of the PR and between 7ce696b and 6bea0e5.

📒 Files selected for processing (21)
  • samples/cpp/video_generation/CMakeLists.txt
  • samples/cpp/video_generation/README.md
  • samples/cpp/video_generation/lora_text2video.cpp
  • samples/python/video_generation/README.md
  • samples/python/video_generation/lora_text2video.py
  • site/docs/guides/lora-adapters.mdx
  • site/docs/use-cases/video-generation/_sections/_usage_options/index.mdx
  • src/cpp/include/openvino/genai/lora_adapter.hpp
  • src/cpp/include/openvino/genai/video_generation/generation_config.hpp
  • src/cpp/include/openvino/genai/video_generation/ltx_video_transformer_3d_model.hpp
  • src/cpp/src/lora/adapter.cpp
  • src/cpp/src/lora/names_mapping.hpp
  • src/cpp/src/video_generation/generation_config_utils.cpp
  • src/cpp/src/video_generation/ltx_pipeline.hpp
  • src/cpp/src/video_generation/models/ltx_video_transformer_3d_model.cpp
  • src/python/openvino_genai/py_openvino_genai.pyi
  • src/python/py_video_generation_models.cpp
  • src/python/py_video_generation_pipelines.cpp
  • tests/python_tests/samples/conftest.py
  • tests/python_tests/samples/test_lora_text2video.py
  • tests/python_tests/test_video_generation.py

📝 Walkthrough

Walkthrough

This pull request systematically removes LoRA adapter support from video generation across the OpenVINO GenAI framework. The changes eliminate sample programs, CMake build rules, public API methods and fields, implementation code, test suites, and documentation references to LoRA adapters in video generation, while updating guidance toward INT8 model usage.

Changes

Cohort / File(s) Summary
Build Configuration
samples/cpp/video_generation/CMakeLists.txt
Removed the lora_text2video executable target, including add_executable, include directories, library linkage, and install rules.
C++ Samples
samples/cpp/video_generation/lora_text2video.cpp
Deleted the entire LoRA-based text-to-video sample program, including argument parsing, pipeline configuration with LoRA adapters, dual-run generation (with/without adapters), and performance metrics reporting.
Python Samples
samples/python/video_generation/lora_text2video.py
Removed Python CLI tool for LoRA-based video generation with multi-adapter support, AdapterConfig construction, and dual-run execution logic.
Sample Documentation
samples/cpp/video_generation/README.md, samples/python/video_generation/README.md
Updated examples to INT8 weight format and model paths; removed LoRA-related sections and download/run instructions; changed output naming from dual videos to single genai_video.avi; added INT8 compression details and callback examples.
Public C++ API Headers
src/cpp/include/openvino/genai/lora_adapter.hpp, src/cpp/include/openvino/genai/video_generation/generation_config.hpp, src/cpp/include/openvino/genai/video_generation/ltx_video_transformer_3d_model.hpp
Removed forward declaration of AdapterConfig, adapter include from VideoGenerationConfig, the adapters field from VideoGenerationConfig, and the set_adapters() method from LTXVideoTransformer3DModel.
C++ Implementation
src/cpp/src/lora/adapter.cpp, src/cpp/src/lora/names_mapping.hpp, src/cpp/src/video_generation/generation_config_utils.cpp, src/cpp/src/video_generation/ltx_pipeline.hpp, src/cpp/src/video_generation/models/ltx_video_transformer_3d_model.cpp
Removed detect_lora_prefix() helper function, adapter field updates in config utilities, adapter propagation calls in pipeline constructors and generate(), and adapter compilation logic including AdapterController instantiation.
Python API Bindings
src/python/openvino_genai/py_openvino_genai.pyi, src/python/py_video_generation_models.cpp, src/python/py_video_generation_pipelines.cpp
Removed set_adapters() method signature from LTXVideoTransformer3DModel stub; removed Python bindings for set_adapters() C++ method and adapters field in VideoGenerationConfig.
Documentation
site/docs/guides/lora-adapters.mdx, site/docs/use-cases/video-generation/_sections/_usage_options/index.mdx
Removed video generation from list of supported LoRA pipelines; deleted entire "Working with LoRA Adapters" section and its documentation link.
Test Suites
tests/python_tests/samples/conftest.py, tests/python_tests/samples/test_lora_text2video.py, tests/python_tests/test_video_generation.py
Removed test file download entry for LoRA dummy model; deleted entire LoRA sample test class and parameterized invocations; removed TestLoRAVideoGeneration class with four test methods (test_lora_adapters_constructor, test_lora_adapters_generate, test_lora_adapters_default_from_constructor, test_transformer_has_set_adapters_method).

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~22 minutes

Poem

🐰 A LoRA farewell, oh how it goes,
Adapters removed like winter snows,
INT8 now lights the video's way,
Simpler pipelines, cleaner each day!
No more dual runs—one path shines bright,
The framework hops forward with all its might!

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch revert-27-fix-lora-video-support
📝 Coding Plan
  • Generate coding plan for human review comments

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts prior work that added LoRA adapter support to the LTX (text-to-video) pipeline, removing the associated C++/Python API surface, tests, docs, and samples.

Changes:

  • Remove LoRA adapter plumbing from the video-generation C++ pipeline/model code paths.
  • Remove Python bindings/stubs that exposed video-generation LoRA configuration and methods.
  • Delete LoRA text-to-video samples/tests and update documentation to no longer claim video-generation LoRA support.

Reviewed changes

Copilot reviewed 21 out of 21 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
tests/python_tests/test_video_generation.py Removes LoRA-related video-generation tests.
tests/python_tests/samples/test_lora_text2video.py Deletes LoRA text-to-video sample test.
tests/python_tests/samples/conftest.py Removes LoRA test artifact download mapping.
src/python/py_video_generation_pipelines.cpp Removes VideoGenerationConfig.adapters exposure in pybind.
src/python/py_video_generation_models.cpp Removes LTXVideoTransformer3DModel.set_adapters binding.
src/python/openvino_genai/py_openvino_genai.pyi Updates Python stubs to drop video-generation adapter API.
src/cpp/src/video_generation/models/ltx_video_transformer_3d_model.cpp Disables adapters at compile-time for video transformer.
src/cpp/src/video_generation/ltx_pipeline.hpp Removes adapter propagation/application in video pipeline.
src/cpp/src/video_generation/generation_config_utils.cpp Stops reading adapters into VideoGenerationConfig.
src/cpp/src/lora/names_mapping.hpp Removes detect_lora_prefix declaration (used by reverted code).
src/cpp/src/lora/adapter.cpp Removes detect_lora_prefix implementation.
src/cpp/include/openvino/genai/video_generation/ltx_video_transformer_3d_model.hpp Removes set_adapters API and adapter-related members.
src/cpp/include/openvino/genai/video_generation/generation_config.hpp Removes adapters from VideoGenerationConfig.
src/cpp/include/openvino/genai/lora_adapter.hpp Removes friend/forward decl related to detect_lora_prefix.
site/docs/use-cases/video-generation/_sections/_usage_options/index.mdx Removes LoRA-adapters section from video generation docs.
site/docs/guides/lora-adapters.mdx Removes claim that LoRA is supported for video generation.
samples/python/video_generation/lora_text2video.py Deletes Python LoRA text-to-video sample.
samples/python/video_generation/README.md Removes LoRA sample docs; updates conversion instructions to INT8 example.
samples/cpp/video_generation/lora_text2video.cpp Deletes C++ LoRA text-to-video sample.
samples/cpp/video_generation/README.md Removes LoRA sample docs; updates conversion instructions to INT8 example.
samples/cpp/video_generation/CMakeLists.txt Stops building/installing the LoRA video sample binary.

You can also share your feedback on Copilot code review. Take the survey.

adapters->set_tensor_name_prefix(m_lora_prefix);
m_adapter_controller = AdapterController(m_model, *adapters, device);
}
OPENVINO_ASSERT(!adapters, "Adapters are not currently supported for Video Generation Pipeline.");
@coderabbitai coderabbitai bot mentioned this pull request Mar 22, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants