Skip to content

Continue the Duration query handling even if gst_pad_peer_query fails. #15

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jadarve wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Continue the Duration query handling even if gst_pad_peer_query fails. #15

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a952fdb
Continue the Duration query handling even if gst_pad_peer_query fails.
jadarve Mar 10, 2026
19fa0bc
Merge branch 'main' into intersink_support
DenizUgur Mar 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 4 additions & 7 deletions src/lib/conversion/pid/query_handlers.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,7 @@
QUERY_HANDLER_SIGNATURE(duration)
{
const GF_PropertyValue* p;
gint64 duration = -1;

// For text streams, we do not set duration
p = gf_filter_pid_get_property(pid, GF_PROP_PID_STREAM_TYPE);
Expand All @@ -56,15 +57,11 @@ QUERY_HANDLER_SIGNATURE(duration)
g_autoptr(GstQuery) query = gst_query_new_duration(GST_FORMAT_TIME);
gboolean ret = gst_pad_peer_query(priv->self, query);
if (!ret) {
GST_ELEMENT_ERROR(
element, LIBRARY, FAILED, (NULL), ("Failed to query duration"));
return FALSE;
GST_ERROR("Failed to query duration");
} else {
gst_query_parse_duration(query, NULL, &duration);
}

// Parse the duration
gint64 duration;
gst_query_parse_duration(query, NULL, &duration);

// Get the fps from the PID
GF_Fraction fps = { 30, 1 };
p = gf_filter_pid_get_property(pid, GF_PROP_PID_FPS);
Expand Down
Loading