Double check me on this one please #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DollarStoreThor
temporarily deployed
to
github-pages-test
GitHub Actions
Inactive
There was a problem hiding this comment.
Pull Request Overview
This PR makes two changes: corrects a percentage calculation in a Jupyter notebook activity and adds a new Unit 2 Competition entry to the notebook configuration.
- Fixes the mean improvement calculation to properly convert to percentage format (multiplying by 100)
- Adds a new Unit 2 Competition section with a student submission entry to the notebook registry
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| notebooks/unit2/lesson_16/Lesson_16_activity.ipynb | Corrects the mean_improvement calculation by multiplying by 100 to match the percentage format in the print statement |
| notebooks/notebooks.yml | Adds a new Unit2_Competition section with a student submission entry |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| - number: "Unit2_Competition" | ||
| title: "Unit 2 Competition" | ||
| topics: "Become Obsesive about a r2" |
There was a problem hiding this comment.
Spelling error: "Obsesive" should be "Obsessive".
Suggested change
| topics: "Become Obsesive about a r2" | |
| topics: "Become Obsessive about a r2" |
DollarStoreThor
commented
Nov 21, 2025
Collaborator
Author
DollarStoreThor
left a comment
DollarStoreThor
left a comment
There was a problem hiding this comment.
Good CoPilot
gperdrizet
approved these changes
Nov 21, 2025
gperdrizet
approved these changes
Nov 21, 2025
gperdrizet
pushed a commit
that referenced
this pull request
Dec 4, 2025
Double check me on this one please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I haven't done a pull request from this side of things before, so just give this a once over so I don't break the site.