Skip to content

Conversation

@aaronw2
Copy link

@aaronw2 aaronw2 commented May 5, 2020

This keychain had an unsupported flash as well as an unexpected
value in the expected string. Once the driver accepts that unexpected
value it seems to work.

Signed-off-by: Aaron Williams [email protected]

This keychain had an unsupported flash as well as an unexpected
value in the expected string.  Once the driver accepts that unexpected
value it seems to work.

Signed-off-by: Aaron Williams <[email protected]>
@jwrdegoede
Copy link
Contributor

Thank you for your pull-req for this. There are really 3 sets of changes in here:

  1. It seems that your editor has removed trailing whitespace in various places, that is good, but that really should be a in a cleanup commit by itself
  2. The addition of the new eeprom model
  3. Accepting buf[7] containing 0x52 in the parameter block validation code

Ideally this would be split out in 3 separate commits. Also please add a comment to the 0x52 check that some newer AX206-3.5.x models have 0x52 in byte 7.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants