Skip to content

Fix submission scrolling bug for virtualized codeblocks #225

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Jack-Khuu merged 1 commit into from
Mar 11, 2026
+7 −5
Merged

Fix submission scrolling bug for virtualized codeblocks #225

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions frontend/src/components/codeblock/CodeBlock.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,11 +152,11 @@ export default React.memo(function CodeBlock({ code, bordered = false }: CodeBlo
<Box
sx={{
...styles.container,
display: "flex",
flexDirection: "column",
flex: 1,
minHeight: 0,
...(canVirtualize && {
display: "flex",
flexDirection: "column",
flex: 1,
minHeight: 0,
overflow: "hidden",
}),
}}
Expand All @@ -174,8 +174,10 @@ export default React.memo(function CodeBlock({ code, bordered = false }: CodeBlo
<Box
ref={canVirtualize ? containerRef : undefined}
sx={{
flex: 1,
minHeight: 0,
...(canVirtualize
? { flex: 1, minHeight: 0, overflow: "hidden" }
? { overflow: "hidden" }
: { overflowY: "auto" }),
...(bordered && {
border: `1px solid ${theme.palette.divider}`,
Expand Down
Loading