Conversation
There was a problem hiding this comment.
Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.
Files not reviewed (2)
- rust/.gitignore: Language not supported
- rust/build.sh: Language not supported
Comments suppressed due to low confidence (1)
rust/src/models/mod.rs:27
- [nitpick] The field name 'title_text' in GpuItem might be less clear given its usage; consider renaming it to 'name' for better clarity and consistency.
pub struct GpuItem {
Comment on lines
+29
to
+31
| if arg == "gpu" || arg == "gpus" { | ||
| gpus = parts[2..].iter().map(|s| s.to_string()).collect(); | ||
| } else if arg == "leaderboard" && parts.len() > 2 { |
There was a problem hiding this comment.
The GPU directive branch uses parts[2..] without ensuring that the directive includes GPU identifiers. Consider adding a check to ensure parts.len() >= 3 before accessing parts[2..].
Suggested change
| if arg == "gpu" || arg == "gpus" { | |
| gpus = parts[2..].iter().map(|s| s.to_string()).collect(); | |
| } else if arg == "leaderboard" && parts.len() > 2 { | |
| if (arg == "gpu" || arg == "gpus") && parts.len() >= 3 { | |
| gpus = parts[2..].iter().map(|s| s.to_string()).collect(); | |
| } else if arg == "leaderboard" && parts.len() >= 3 { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This works right now, I managed to push a job and get results back in the terminal https://github.com/gpu-mode/discord-cluster-manager/actions/runs/14344920618
To install
./build.shSome pending issues
This completely borks the terminal output after running it once so looks quite uglyDoesn't anymore 💪Logs