hide benchmark args by loading them from a temp file#11
Open
teelaitila wants to merge 1 commit intogpu-mode:masterfrom
Open
hide benchmark args by loading them from a temp file#11teelaitila wants to merge 1 commit intogpu-mode:masterfrom
teelaitila wants to merge 1 commit intogpu-mode:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3.
This updates
do_bench_isolated(...)to hide benchmarktest_argsfrom Python stack inspection by serializing them to a temp file and loading them inside a wrapped test-case generator, instead of passing them directly as kwargs into the benchmark call.