feat: add explicit inputs/outputs protocol#12
Open
teelaitila wants to merge 1 commit intogpu-mode:masterfrom
Open
feat: add explicit inputs/outputs protocol#12teelaitila wants to merge 1 commit intogpu-mode:masterfrom
teelaitila wants to merge 1 commit intogpu-mode:masterfrom
Conversation
Collaborator
|
there are also in/out args, such as C += AB in a gemm. Would be nice if we could support this, too, and I'm not sure if this approach generalizes well. Otherwise, I like it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note: This is my take on solving this. Totally happy to adjust direction or make changes if you think there’s a better way.
Introduces an explicit multi-output test-case protocol:
test_generator now returns:
What changed
inputs,outputs, andexpectedseparate.kernel(*outputs, *inputs).Note
This is a breaking change for
test_generatorreturn format.Old:
New:
Tested on Modal with both single-output and multi-output grayscale cases.