Skip to content

Add some texture builtin debug info.#4409

Merged
greggman merged 1 commit into
gpuweb:mainfrom
greggman:texture-debug-info
Jun 25, 2025
Merged

Add some texture builtin debug info.#4409
greggman merged 1 commit into
gpuweb:mainfrom
greggman:texture-debug-info

Conversation

@greggman

Copy link
Copy Markdown
Contributor

This info only shows if debug=1 or --debug-cts (dawn.node) is passed in. It's useful for seeing the calls even when there are no errors.

Screenshot 2025-06-24 at 16 24 06

@greggman greggman force-pushed the texture-debug-info branch from 6229157 to e70c3a8 Compare June 25, 2025 00:12
@greggman greggman enabled auto-merge (squash) June 25, 2025 00:13
@greggman greggman requested a review from shrekshao June 25, 2025 00:16

@shrekshao shrekshao left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
(only concern: I think t.debug(func()) still exec func() regardless of if debug or not. If this is not a slow tests then it's fine)

@kainino0x

kainino0x commented Jun 25, 2025

Copy link
Copy Markdown
Collaborator

t.debug should probably optionally take a () => string function (like skipIf and some other things)

@greggman greggman force-pushed the texture-debug-info branch from e70c3a8 to 98d6bbb Compare June 25, 2025 13:18
This info only shows if `debug=1` or `--debug-cts` (dawn.node)
is passed in. It's useful for seeing the calls even when there
are no errors.
@greggman greggman force-pushed the texture-debug-info branch from 98d6bbb to 449cb94 Compare June 25, 2025 13:23
@greggman greggman merged commit 9dc0672 into gpuweb:main Jun 25, 2025
1 check passed
@greggman greggman deleted the texture-debug-info branch June 25, 2025 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants