Skip to content

Test Reusing the same query in the same command buffer#4626

Merged
greggman merged 1 commit into
gpuweb:mainfrom
greggman:add-query-reuse-tests
Apr 18, 2026
Merged

Test Reusing the same query in the same command buffer#4626
greggman merged 1 commit into
gpuweb:mainfrom
greggman:add-query-reuse-tests

Conversation

@greggman
Copy link
Copy Markdown
Contributor

@greggman greggman commented Apr 16, 2026

Queries are not allowed to be used more than once in the same render pass but they are allowed to be used more than once in the same command buffer, without resolving inbetween use.

Add a test this works as expected.


Requirements for PR author:

  • All missing test coverage is tracked with "TODO" or .unimplemented().
  • New helpers are /** documented */ and new helper files are found in helper_index.txt.
  • Test behaves as expected in a WebGPU implementation. (If not passing, explain above.)
  • Test have be tested with compatibility mode validation enabled and behave as expected. (If not passing, explain above.)

Requirements for reviewer sign-off:

  • Tests are properly located.
  • Test descriptions are accurate and complete.
  • Tests provide complete coverage (including validation control cases). Missing coverage MUST be covered by TODOs.
  • Tests avoid over-parameterization (see case count report).

When landing this PR, be sure to make any necessary issue status updates.

@greggman greggman requested a review from kainino0x April 16, 2026 23:51
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 16, 2026

Results for build job (at 5d64722):

+webgpu:api,operation,command_buffer,queries,occlusionQuery:occlusion_query,reuse:* - 32 cases, 32 subcases (~1/case)
-TOTAL: 280764 cases, 2322103 subcases
+TOTAL: 280796 cases, 2322135 subcases

Queries are not allowed to be used more than once in
the same render pass but they are allowed to be used
more than once in the same command buffer, without
resolving inbetween use.

Add a test this works as expected.
@greggman greggman force-pushed the add-query-reuse-tests branch from 584a95b to 5d64722 Compare April 18, 2026 01:55
@greggman greggman enabled auto-merge (squash) April 18, 2026 01:55
@greggman greggman merged commit 3962314 into gpuweb:main Apr 18, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants