Add support for serialize_nulls build config option#403
Draft
twklessor wants to merge 8 commits intogql-dart:masterfrom
Draft
Add support for serialize_nulls build config option#403twklessor wants to merge 8 commits intogql-dart:masterfrom
twklessor wants to merge 8 commits intogql-dart:masterfrom
Conversation
Collaborator
|
Thanks! I'll take a look at it soon. |
Collaborator
|
So, to get on the same page: You want a feature that always includes all null values when serialization, right? Afaik this can be done in a much more simple way by just adding
as an annotation to the serializer, no custom serializer is needed for that. The Custom Serializer was needed to have the distinction between absent and null values. |
Author
|
Yes that's right. I almost expected you to have an easier solution. To be honest I used the work you'd already done in the branch with the |
Author
|
Sorry to come back months later but what is the status of this? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for serialize_nulls build config option. This option will enable that null fields are always serialized as null.