Conversation
klavs
commented
Feb 23, 2020
| final type = shape.$__typename; | ||
| final area = shape.area; | ||
|
|
||
| final square = shape.asSquare(); |
Contributor
Author
There was a problem hiding this comment.
@smkhalsa, here's the API I originally imagined. What do you think? I like this approach because it lets user avoid using generated classes directly.
Member
There was a problem hiding this comment.
One minor note: if we did this, we'd probably want to prefix the asSubclass() methods with $ to avoid collisions with data fields.
What I like about using the generated subclasses directly is that if (class is classAsSubclass) feels intuitive and doesn't require any additional typecasting.
That said, if we did go this route, it would feel more intuitive to me to also have a $isSubclass property rather than checking for null with the $asSubclass() method.
if (shape.$isSquare) {
final square = shape.$asSquare();
return "$type(area: $area, sideLength: ${square.sideLength})";
}
if (shape.$isRectangle) {
final rectangle = shape.$asRectangle();
return "$type(area: $area, sideLengthA: ${rectangle.sideLengthA}, sideLengthB: ${rectangle.sideLengthB})";
}d592e79 to
64dfaeb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__typenamefield to object and interface definitions