chore(country-items): Update cart item model to include seller country [TA-10180]#21
Merged
FedericoGelsi merged 4 commits intomainfrom Mar 11, 2025
Conversation
luca-gr4vy
reviewed
Mar 11, 2025
gr4vy-iOS/Models/Gr4vyCartItem.swift
Outdated
| @@ -1,5 +1,5 @@ | |||
| // | |||
| // Gr4vyCartItem.swift | |||
| // Gr4vy5.swift | |||
Contributor
There was a problem hiding this comment.
Can you revert this comment change?
Contributor
|
Looks good (just that comment thing), can you also bump the version in here? https://github.com/gr4vy/gr4vy-ios/blob/TA-10180-update-cart-item-model-to-include-seller-country/gr4vy-ios.podspec#L3 Can be |
luca-gr4vy
approved these changes
Mar 11, 2025
JohnnyDevi
pushed a commit
to JohnnyDevi/gr4vy-ios
that referenced
this pull request
Apr 3, 2025
* commit 'df62515018bf0bb23883e9edb572d836c8118155': task: use supported schemes for Apple Pay (gr4vy#22) chore(country-items): Update cart item model to include seller country [TA-10180] (gr4vy#21) bump version (gr4vy#19) chore: add the preselect store option to readme (gr4vy#18) bump version (gr4vy#17) refactor: add preferAuthorize intent to the README (gr4vy#16)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira: TA-10180
Added
sellerCountrytoGr4vyCartItemto support sending this new prop to core-api.Updated
README.mdwith this new optional prop.Tested on
spider-sandboxand it works fine withcybsconnector.