Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JUnit feature #693

Draft
wants to merge 20 commits into
base: master
Choose a base branch
from
Draft

Conversation

dnestoro
Copy link
Collaborator

@dnestoro dnestoro commented Feb 12, 2025

This PR:

@oracle-contributor-agreement oracle-contributor-agreement bot added the OCA Verified All contributors have signed the Oracle Contributor Agreement. label Feb 12, 2025
Copy link
Collaborator

@melix melix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks David. Can you give a description of the changes that this makes? For example you mention that the tests are discovered at runtime but in practice you are still using the test-ids.

There are changes which need to be reverted on the samples: build plugins versions and maven repositories.

@dnestoro
Copy link
Collaborator Author

Thanks David. Can you give a description of the changes that this makes? For example you mention that the tests are discovered at runtime but in practice you are still using the test-ids.

There are changes which need to be reverted on the samples: build plugins versions and maven repositories.

Hey @melix the PR is not ready yet (it is in draft state). I will update PR description and revert unnecessary changes after I finish testing.

@dnestoro dnestoro force-pushed the dnestoro/refactor-junit-feature branch from 88c100d to 571acc3 Compare February 18, 2025 15:18
@dnestoro dnestoro force-pushed the dnestoro/refactor-junit-feature branch from 29c75fe to b80fd65 Compare February 21, 2025 01:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OCA Verified All contributors have signed the Oracle Contributor Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants