Skip to content

Fix ICE candidate parsing #412

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
ketsapiwiq wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Fix ICE candidate parsing #412

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion backend/fastrtc/webrtc_connection_mixin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -245,8 +245,9 @@ async def handle_offer(self, body, set_outputs):
candidate_str = body["candidate"].get("candidate", "")

# Example format: "candidate:2393089663 1 udp 2122260223 192.168.86.60 63692 typ host generation 0 ufrag LkZb network-id 1 network-cost 10"
# Also support shorter format: "candidate:0 1 UDP 2122187007 192.168.1.52 38846 typ host"
parts = candidate_str.split()
if len(parts) >= 10 and parts[0].startswith("candidate:"):
if len(parts) >= 8 and parts[0].startswith("candidate:"):
foundation = parts[0].split(":", 1)[1]
component = int(parts[1])
protocol = parts[2]
Expand Down