-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix: Adjusted padding for icon button wrapper for better layout. #11995
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
🪼 branch checks and previews
Install Gradio from this PR pip install https://gradio-pypi-previews.s3.amazonaws.com/64c64c9bace3c7a13e155658d74a55055747ec6f/gradio-5.47.2-py3-none-any.whl Install Gradio Python Client from this PR pip install "gradio-client @ git+https://github.com/gradio-app/gradio@64c64c9bace3c7a13e155658d74a55055747ec6f#subdirectory=client/python" Install Gradio JS Client from this PR npm install https://gradio-npm-previews.s3.amazonaws.com/64c64c9bace3c7a13e155658d74a55055747ec6f/gradio-client-1.19.0.tgz |
🦄 change detectedThis Pull Request includes changes to the following packages.
|
Hi @PRIME-SV ! Looks like the button row is visible even when the image component does not have a value. I also am not entirely sure what the issue is with the original behavior. ![]() |
Hi @freddyaboulton , And regarding this present issue partial visibility button row even when the image component does not have a value, I am not sure about that. |
Hi @freddyaboulton , |
Hi @freddyaboulton @hannahblair , |
![]() I'm not sure if this is the solution @PRIME-SV as it looks a bit oddly spaced. That said, I'm not sure what a better solution is to this. I'll have a think about this! |
Sure @hannahblair. |
Description
Added the padding to the IconButtonWrapper so that the scroll bar won't overlap with the button control.
Closes: #11982
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.sh
Please run these bash scripts to automatically format your code:
bash scripts/format_backend.sh
, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh