Skip to content

Conversation

PRIME-SV
Copy link
Contributor

Description

Added the padding to the IconButtonWrapper so that the scroll bar won't overlap with the button control.

Closes: #11982

🎯 PRs Should Target Issues

Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.

Not adhering to this guideline will result in the PR being closed.

Testing and Formatting Your Code

  1. PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests: bash scripts/run_backend_tests.sh

  2. Please run these bash scripts to automatically format your code: bash scripts/format_backend.sh, and (if you made any changes to non-Python files) bash scripts/format_frontend.sh

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 30, 2025

🪼 branch checks and previews

Name Status URL
Spaces ready! Spaces preview
Website ready! Website preview
Storybook ready! Storybook preview
🦄 Changes detected! Details

Install Gradio from this PR

pip install https://gradio-pypi-previews.s3.amazonaws.com/64c64c9bace3c7a13e155658d74a55055747ec6f/gradio-5.47.2-py3-none-any.whl

Install Gradio Python Client from this PR

pip install "gradio-client @ git+https://github.com/gradio-app/gradio@64c64c9bace3c7a13e155658d74a55055747ec6f#subdirectory=client/python"

Install Gradio JS Client from this PR

npm install https://gradio-npm-previews.s3.amazonaws.com/64c64c9bace3c7a13e155658d74a55055747ec6f/gradio-client-1.19.0.tgz

@gradio-pr-bot
Copy link
Collaborator

gradio-pr-bot commented Sep 30, 2025

🦄 change detected

This Pull Request includes changes to the following packages.

Package Version
@gradio/atoms patch
@gradio/image patch
gradio patch

  • Fix: Adjusted padding for icon button wrapper for better layout.

‼️ Changeset not approved. Ensure the version bump is appropriate for all packages before approving.

  • Maintainers can approve the changeset by checking this checkbox.

Something isn't right?

  • Maintainers can change the version label to modify the version bump.
  • If the bot has failed to detect any changes, or if this pull request needs to update multiple packages to different versions or requires a more comprehensive changelog entry, maintainers can update the changelog file directly.

@hannahblair hannahblair self-requested a review September 30, 2025 21:40
@freddyaboulton
Copy link
Collaborator

Hi @PRIME-SV ! Looks like the button row is visible even when the image component does not have a value. I also am not entirely sure what the issue is with the original behavior.

image

@PRIME-SV
Copy link
Contributor Author

PRIME-SV commented Oct 1, 2025

Hi @freddyaboulton ,
The issue was regarding the visibility of Remove button when the scroll bar appears on the screen in Full screen image mode.
The problem was that the scroll bar would overlap over the remove button making it invisible/inaccessible.
I have a added the padding so that even though the scroll viewer appears it won't overlap with the remove button.

And regarding this present issue partial visibility button row even when the image component does not have a value, I am not sure about that.

@PRIME-SV
Copy link
Contributor Author

PRIME-SV commented Oct 1, 2025

Hi @freddyaboulton ,
I can see partial visibility of button row even when the image component does not have a value is the side effect of this fix.
I will resolve that and update the PR.

@PRIME-SV
Copy link
Contributor Author

PRIME-SV commented Oct 1, 2025

Hi @freddyaboulton @hannahblair ,
Updated the PR to fix issue.
Please review

@hannahblair
Copy link
Collaborator

Screenshot 2025-10-01 at 19 16 10

I'm not sure if this is the solution @PRIME-SV as it looks a bit oddly spaced.

That said, I'm not sure what a better solution is to this. I'll have a think about this!

@PRIME-SV
Copy link
Contributor Author

PRIME-SV commented Oct 1, 2025

Sure @hannahblair.

@hannahblair hannahblair marked this pull request as draft October 1, 2025 20:31
@PRIME-SV PRIME-SV marked this pull request as ready for review October 1, 2025 20:55
@PRIME-SV PRIME-SV marked this pull request as draft October 1, 2025 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The 'Download' and Remove Image' buttons move beyond the visible area in full-screen mode at high image resolutions.

4 participants