fix: gradio_api path in mount_gradio_app#12803
Open
shandowc wants to merge 4 commits intogradio-app:mainfrom
Open
fix: gradio_api path in mount_gradio_app#12803shandowc wants to merge 4 commits intogradio-app:mainfrom
shandowc wants to merge 4 commits intogradio-app:mainfrom
Conversation
1e03437 to
034df7e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request fixes a bug where custom component assets (CSS and JS files) return 404 errors when a Gradio app is mounted at a subpath using gr.mount_gradio_app(). The issue occurred because the frontend was incorrectly constructing the API URL using JavaScript's URL constructor, which doesn't properly preserve the mount path.
Changes:
- Introduced a new
get_api_url()helper function that correctly concatenates the root path and API prefix - Replaced direct
new URL(config.api_prefix, config.root)calls with the new helper function in two locations within theAppTreeclass
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Author
|
@freddyaboulton could you plz review this pr? |
|
Hi, Any update on this PR? |
3 tasks
Collaborator
|
Will take a look! Sorry for the delay. We were waiting on #12879 |
# Conflicts: # js/core/src/init.test.skip.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When mounting a Gradio app to a FastAPI application at a subpath using
gr.mount_gradio_app(), custom component assets (CSS and JS files) return 404 errors because the frontend requests don't include the mount path prefix.Closes: #12802
AI Disclosure
We encourage the use of AI tooling in creating PRs, but the any non-trivial use of AI needs be disclosed. E.g. if you used Claude to write a first draft, you should mention that. Trivial tab-completion doesn't need to be disclosed. You should self-review all PRs, especially if they were generated with AI.
🎯 PRs Should Target Issues
Before your create a PR, please check to see if there is an existing issue for this change. If not, please create an issue before you create this PR, unless the fix is very small.
Not adhering to this guideline will result in the PR being closed.
Testing and Formatting Your Code
PRs will only be merged if tests pass on CI. We recommend at least running the backend tests locally, please set up your Gradio environment locally and run the backed tests:
bash scripts/run_backend_tests.shPlease run these bash scripts to automatically format your code:
bash scripts/format_backend.sh, and (if you made any changes to non-Python files)bash scripts/format_frontend.sh