Fix clipboard z-index overlap with Dataframe cell menu#13011
Closed
gambletan wants to merge 2 commits intogradio-app:mainfrom
Closed
Fix clipboard z-index overlap with Dataframe cell menu#13011gambletan wants to merge 2 commits intogradio-app:mainfrom
gambletan wants to merge 2 commits intogradio-app:mainfrom
Conversation
The CellMenu context menu in gr.Dataframe used z-index: var(--layer-1), which is lower than the IconButtonWrapper's z-index: var(--layer-2) used by clipboard copy buttons in gr.JSON and gr.Markdown. This caused the copy button to render above the context menu. Raise CellMenu z-index to var(--layer-3) and remove the duplicate z-index: 9 declaration. Fixes gradio-app#11561
Collaborator
|
Duplicate of #13008 . please refrain from opening duplicate prs. Especially if it is entirely ai generated. It is rude. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gr.Dataframecell's context menu #11561CellMenucontext menu ingr.Dataframeusedz-index: var(--layer-1), which is lower than theIconButtonWrapper'sz-index: var(--layer-2)used by clipboard copy buttons ingr.JSONandgr.Markdown. This caused the copy button to render above the context menu when they overlapped.CellMenuz-index tovar(--layer-3)so it always renders above other component UI elements like copy buttons.z-index: 9declaration that was being overridden.Test plan
gr.Dataframenext to agr.JSON(show_copy_button=True)componentgr.Markdown(show_copy_button=True)gr.Textboxandgr.Numbercopy buttons also remain behind the context menu🤖 Generated with Claude Code