fix: prevent infinite resize loop with fill_height when footer_links=[]#13015
Closed
Ker102 wants to merge 1 commit intogradio-app:mainfrom
Closed
fix: prevent infinite resize loop with fill_height when footer_links=[]#13015Ker102 wants to merge 1 commit intogradio-app:mainfrom
fill_height when footer_links=[]#13015Ker102 wants to merge 1 commit intogradio-app:mainfrom
Conversation
When fill_height=True and footer_links=[], the footer element is removed from the DOM. The ResizeObserver fires handle_resize() which calls parentIFrame.size() to tell the host iframe the content height. Without the footer acting as a stable boundary, the flex container with fill_height keeps growing to fill the new space, triggering the ResizeObserver again in an infinite loop. Fix: track the last reported height and skip parentIFrame.size() calls when the computed height hasn't changed, breaking the feedback loop. Fixes gradio-app#12992
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closing this — after further analysis I realized the height dedup approach doesn't actually stop the feedback loop, since
box.bottomgenuinely increases each cycle as the flex container stretches to fill the resized iframe. The core issue needsparentIFrame.size()to be skipped entirely whenfill_heightis true, not just deduplicated.Sorry for the noise.